Clarify error messaging for transfers

Author: DaneEveritt

app/Exceptions/Http/Server/ServerTransferringException.php

@@ -7,8 +7,11 @@
 
 class ServerTransferringException extends HttpException
 {
+    /**
+     * ServerTransferringException constructor.
+     */
     public function __construct()
     {
-        parent::__construct(Response::HTTP_CONFLICT, 'Server is currently being transferred.');
+        parent::__construct(Response::HTTP_CONFLICT, 'This server is currently being transferred to a new machine, please try again laster.');
     }
 }

app/Http/Controllers/Api/Remote/SftpAuthenticationController.php

@@ -113,7 +113,7 @@ public function __invoke(SftpAuthenticationFormRequest $request): JsonResponse
 
         // Prevent SFTP access to servers that are being transferred.
         if (! is_null($server->transfer)) {
-            throw new ServerTransferringException();
+            throw new ServerTransferringException;
         }
 
         // Remember, for security purposes, only reveal the existence of the server to people that

app/Http/Middleware/Api/Client/Server/AuthenticateServerAccess.php

@@ -82,7 +82,7 @@ public function handle(Request $request, Closure $next)
 
             if (! is_null($server->transfer)) {
                 if (! $user->root_admin || ($user->root_admin && ! $request->routeIs($this->except))) {
-                    throw new ServerTransferringException();
+                    throw new ServerTransferringException;
                 }
             }
         }

app/Http/Middleware/Server/AccessingValidServer.php

@@ -83,7 +83,7 @@ public function handle(Request $request, Closure $next)
 
         if (! is_null($server->transfer)) {
             if ($isApiRequest) {
-                throw new ServerTransferringException();
+                throw new ServerTransferringException;
             }
 
             return $this->response->view('errors.transferring', [], 409);

app/Services/Servers/SuspensionService.php

@@ -60,7 +60,7 @@ public function toggle(Server $server, $action = self::ACTION_SUSPEND)
 
         // Check if the server is currently being transferred.
         if (! is_null($server->transfer)) {
-            throw new ServerTransferringException();
+            throw new ServerTransferringException;
         }
 
         $this->connection->transaction(function () use ($action, $server) {