Fix exception thrown due to lack of pre-validation on the model.

closes pterodactyl#1158

Author: DaneEveritt

CHANGELOG.md

@@ -8,6 +8,7 @@ This project follows [Semantic Versioning](http://semver.org) guidelines.
 * Fixes an issue with the sidebar logo not working correctly in some browsers due to the CSS being assigned.
 * Fixes a bunch of typos through the code base.
 * Fixes a bug when attempting to load the dropdown menu for server owner in some cases.
+* Fixes an exception thrown when the database connection address was not filled out correctly while adding a database to a server.
 
 ### Added
 * Added a new client API endpoint for gathering the utilization stats for servers including disk, cpu, and memory. `GET /api/client/servers/<id>/utilization`

app/Http/Controllers/Admin/ServersController.php

@@ -35,6 +35,7 @@
 use Pterodactyl\Contracts\Repository\DatabaseRepositoryInterface;
 use Pterodactyl\Contracts\Repository\LocationRepositoryInterface;
 use Pterodactyl\Contracts\Repository\AllocationRepositoryInterface;
+use Pterodactyl\Http\Requests\Admin\Servers\Databases\StoreServerDatabaseRequest;
 
 class ServersController extends Controller
 {
@@ -537,7 +538,7 @@ public function delete(Request $request, Server $server)
     /**
      * Update the startup command as well as variables.
      *
-     * @param \Illuminate\Http\Request $request
+     * @param \Illuminate\Http\Request   $request
      * @param \Pterodactyl\Models\Server $server
      * @return \Illuminate\Http\RedirectResponse
      *
@@ -558,15 +559,13 @@ public function saveStartup(Request $request, Server $server)
     /**
      * Creates a new database assigned to a specific server.
      *
-     * @param \Illuminate\Http\Request $request
-     * @param int                      $server
+     * @param \Pterodactyl\Http\Requests\Admin\Servers\Databases\StoreServerDatabaseRequest $request
+     * @param int                                                                           $server
      * @return \Illuminate\Http\RedirectResponse
      *
      * @throws \Exception
-     * @throws \Pterodactyl\Exceptions\DisplayException
-     * @throws \Pterodactyl\Exceptions\Model\DataValidationException
      */
-    public function newDatabase(Request $request, $server)
+    public function newDatabase(StoreServerDatabaseRequest $request, $server)
     {
         $this->databaseManagementService->create($server, [
             'database' => $request->input('database'),

app/Http/Controllers/Api/Application/Servers/DatabaseController.php

@@ -104,8 +104,6 @@ public function resetPassword(ServerDatabaseWriteRequest $request): Response
      * @return \Illuminate\Http\JsonResponse
      *
      * @throws \Exception
-     * @throws \Pterodactyl\Exceptions\DisplayException
-     * @throws \Pterodactyl\Exceptions\Model\DataValidationException
      */
     public function store(StoreServerDatabaseRequest $request): JsonResponse
     {

app/Http/Requests/Admin/Servers/Databases/StoreServerDatabaseRequest.php

@@ -0,0 +1,22 @@
+<?php
+
+namespace Pterodactyl\Http\Requests\Admin\Servers\Databases;
+
+use Pterodactyl\Http\Requests\Admin\AdminFormRequest;
+
+class StoreServerDatabaseRequest extends AdminFormRequest
+{
+    /**
+     * Validation rules for database creation.
+     *
+     * @return array
+     */
+    public function rules(): array
+    {
+        return [
+            'database' => 'required|string|min:1|max:24',
+            'remote' => 'required|string|regex:/^[0-9%.]{1,15}$/',
+            'database_host_id' => 'required|integer|exists:database_hosts,id',
+        ];
+    }
+}

app/Http/Requests/Api/Application/Servers/Databases/StoreServerDatabaseRequest.php

@@ -26,7 +26,7 @@ public function rules(): array
     {
         return [
             'database' => 'required|string|min:1|max:24',
-            'remote' => 'required|string|min:1',
+            'remote' => 'required|string|regex:/^[0-9%.]{1,15}$/',
             'host' => 'required|integer|exists:database_hosts,id',
         ];
     }