Use cache helpers rather than database to handle configuration tokens and downloads.

Author: DaneEveritt

CHANGELOG.md

@@ -20,6 +20,8 @@ This project follows [Semantic Versioning](http://semver.org) guidelines.
 * Environment setting commands now attempt to auto-quote strings with spaces in them, as well as comment lines that are edited to avoid manual changes being overwritten.
 * Version in footer of panel now displays correctly if panel is installed using Git rather than a download from source.
 * Mobile views are now more... viewable. Fixes `col-xs-6` usage thoughout the Admin CP where it was intended to be `col-md-6`.
+* Node Configuration tokens and Download tokens are stored using the cache helpers rather than a database to speed up functions and make use of auto-expiration/deletion functions.
+* Old daemon routes using `/remote` have been changed to use `/daemon`, panel changes now reflect this.
 
 ## v0.6.0-beta.2.1 (Courageous Carniadactylus)
 ### Fixed

app/Http/Controllers/Admin/NodesController.php

@@ -27,6 +27,7 @@
 use DB;
 use Log;
 use Alert;
+use Cache;
 use Javascript;
 use Pterodactyl\Models;
 use Illuminate\Http\Request;
@@ -364,11 +365,9 @@ public function setToken(Request $request, $id)
     {
         $node = Models\Node::findOrFail($id);
 
-        $t = Models\NodeConfigurationToken::create([
-            'node_id' => $id,
-            'token' => str_random(32),
-        ]);
+        $token = str_random(32);
+        Cache::put('NodeConfiguration:' . $token, $node->id, 5);
 
-        return response()->json(['token' => $t->token]);
+        return response()->json(['token' => $token]);
     }
 }

app/Http/Controllers/Daemon/ActionController.php

@@ -24,11 +24,11 @@
 
 namespace Pterodactyl\Http\Controllers\Daemon;
 
+use Cache;
 use Illuminate\Http\Request;
+use Pterodactyl\Models\Node;
 use Pterodactyl\Models\Server;
-use Pterodactyl\Models\Download;
 use Pterodactyl\Http\Controllers\Controller;
-use Pterodactyl\Models\NodeConfigurationToken;
 
 class ActionController extends Controller
 {
@@ -40,18 +40,17 @@ class ActionController extends Controller
      */
     public function authenticateDownload(Request $request)
     {
-        $download = Download::where('token', $request->input('token'))->first();
-        if (! $download) {
+        $download = Cache::pull('Download:' . $request->input('token'));
+
+        if (is_null($download)) {
             return response()->json([
                 'error' => 'An invalid request token was recieved with this request.',
             ], 403);
         }
 
-        $download->delete();
-
         return response()->json([
-            'path' => $download->path,
-            'server' => $download->server,
+            'path' => $download['path'],
+            'server' => $download['server'],
         ]);
     }
 
@@ -94,24 +93,14 @@ public function markInstall(Request $request)
      */
     public function configuration(Request $request, $token)
     {
-        // Try to query the token and the node from the database
-        try {
-            $model = NodeConfigurationToken::with('node')->where('token', $token)->firstOrFail();
-        } catch (\Illuminate\Database\Eloquent\ModelNotFoundException $e) {
+        $nodeId = Cache::pull('NodeConfiguration:' . $token);
+        if (is_null($nodeId)) {
             return response()->json(['error' => 'token_invalid'], 403);
         }
 
-        // Check if token is expired
-        if ($model->created_at->addMinutes(5)->lt(Carbon::now())) {
-            $model->delete();
-
-            return response()->json(['error' => 'token_expired'], 403);
-        }
-
-        // Delete the token, it's one-time use
-        $model->delete();
+        $node = Node::findOrFail($nodeId);
 
         // Manually as getConfigurationAsJson() returns it in correct format already
-        return response($model->node->getConfigurationAsJson())->header('Content-Type', 'text/json');
+        return response($node->getConfigurationAsJson())->header('Content-Type', 'text/json');
     }
 }

app/Http/Controllers/Server/ServerController.php

@@ -25,8 +25,8 @@
 namespace Pterodactyl\Http\Controllers\Server;
 
 use Log;
-use Uuid;
 use Alert;
+use Cache;
 use Pterodactyl\Models;
 use Illuminate\Http\Request;
 use Pterodactyl\Exceptions\DisplayException;
@@ -201,13 +201,11 @@ public function getDownloadFile(Request $request, $uuid, $file)
         $server = Models\Server::byUuid($uuid);
         $this->authorize('download-files', $server);
 
-        $download = new Models\Download;
-
-        $download->token = (string) Uuid::generate(4);
-        $download->server = $server->uuid;
-        $download->path = $file;
-
-        $download->save();
+        $token = str_random(40);
+        Cache::tags(['Downloads', 'Downloads:Server:' . $server->uuid])->put('Download:' . $token, [
+            'server' => $server->uuid,
+            'path' => $file,
+        ], 1);
 
         return redirect($server->node->scheme . '://' . $server->node->fqdn . ':' . $server->node->daemonListen . '/server/file/download/' . $download->token);
     }

app/Models/Download.php

@@ -334,16 +334,6 @@ public function databases()
         return $this->hasMany(Database::class);
     }
 
-    /**
-     * Gets all downloads associated with a server.
-     *
-     * @return \Illuminate\Database\Eloquent\Relations\HasMany
-     */
-    public function downloads()
-    {
-        return $this->hasMany(Download::class, 'server', 'id');
-    }
-
     /**
      * Gets the location of the server.
      *

app/Models/NodeConfigurationToken.php

@@ -138,6 +138,7 @@ public function updated(Server $server)
          */
         Cache::tags('Model:Server:byUuid:' . $server->uuid)->flush();
         Cache::tags('Model:Server:byUuid:' . $server->uuidShort)->flush();
+        Cache::tags('Downloads:Server:' . $server->uuid)->flush();
 
         event(new Events\Server\Updated($server));
     }

app/Models/Server.php

@@ -284,9 +284,6 @@ public function delete($id)
             // Delete Allocations
             Models\Allocation::where('node_id', $node->id)->delete();
 
-            // Delete configure tokens
-            Models\NodeConfigurationToken::where('node_id', $node->id)->delete();
-
             // Delete Node
             $node->delete();
         });

app/Observers/ServerObserver.php

@@ -0,0 +1,34 @@
+<?php
+
+use Illuminate\Support\Facades\Schema;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Database\Migrations\Migration;
+
+class DeleteDownloadTable extends Migration
+{
+    /**
+     * Run the migrations.
+     *
+     * @return void
+     */
+    public function up()
+    {
+        Schema::dropIfExists('downloads');
+    }
+
+    /**
+     * Reverse the migrations.
+     *
+     * @return void
+     */
+    public function down()
+    {
+        Schema::create('downloads', function (Blueprint $table) {
+            $table->increments('id');
+            $table->char('token', 36)->unique();
+            $table->char('server', 36);
+            $table->text('path');
+            $table->timestamps();
+        });
+    }
+}