Decode URL fragments correctly before sending to the daemon; ref pterodactyl#2040 ref pterodactyl#2038

Author: DaneEveritt

app/Repositories/Wings/DaemonFileRepository.php

@@ -2,29 +2,13 @@
 
 namespace Pterodactyl\Repositories\Wings;
 
-use stdClass;
-use Exception;
 use Webmozart\Assert\Assert;
 use Pterodactyl\Models\Server;
 use Psr\Http\Message\ResponseInterface;
 use Pterodactyl\Exceptions\Http\Server\FileSizeTooLargeException;
 
 class DaemonFileRepository extends DaemonRepository
 {
-    /**
-     * Return stat information for a given file.
-     *
-     * @param string $path
-     * @return \stdClass
-     *
-     * @throws \Exception
-     * @throws \GuzzleHttp\Exception\TransferException
-     */
-    public function getFileStat(string $path): stdClass
-    {
-        throw new Exception('Function not implemented.');
-    }
-
     /**
      * Return the contents of a given file.
      *
@@ -55,29 +39,6 @@ public function getContent(string $path, int $notLargerThan = null): string
         return $response->getBody()->__toString();
     }
 
-    /**
-     * Returns a stream of a file's contents back to the calling function to allow
-     * proxying the request through the Panel rather than needing a direct call to
-     * the Daemon in order to work.
-     *
-     * @param string $path
-     * @return \Psr\Http\Message\ResponseInterface
-     */
-    public function streamContent(string $path): ResponseInterface
-    {
-        Assert::isInstanceOf($this->server, Server::class);
-
-        $response = $this->getHttpClient()->get(
-            sprintf('/api/servers/%s/files/contents', $this->server->uuid),
-            [
-                'query' => ['file' => $path, 'download' => true],
-                'stream' => true,
-            ]
-        );
-
-        return $response;
-    }
-
     /**
      * Save new contents to a given file. This works for both creating and updating
      * a file.
@@ -138,8 +99,8 @@ public function createDirectory(string $name, string $path): ResponseInterface
             sprintf('/api/servers/%s/files/create-directory', $this->server->uuid),
             [
                 'json' => [
-                    'name' => $name,
-                    'path' => $path,
+                    'name' => urldecode($name),
+                    'path' => urldecode($path),
                 ],
             ]
         );
@@ -160,8 +121,8 @@ public function renameFile(string $from, string $to): ResponseInterface
             sprintf('/api/servers/%s/files/rename', $this->server->uuid),
             [
                 'json' => [
-                    'rename_from' => $from,
-                    'rename_to' => $to,
+                    'rename_from' => urldecode($from),
+                    'rename_to' => urldecode($to),
                 ],
             ]
         );
@@ -181,7 +142,7 @@ public function copyFile(string $location): ResponseInterface
             sprintf('/api/servers/%s/files/copy', $this->server->uuid),
             [
                 'json' => [
-                    'location' => $location,
+                    'location' => urldecode($location),
                 ],
             ]
         );