Fix IP checking in API middleware, closes pterodactyl#425

DaneEveritt · DaneEveritt · commit 5bdd75eb94fc · 2017-05-06T23:02:12.000-04:00
diff --git a/app/Http/Middleware/HMACAuthorization.php b/app/Http/Middleware/HMACAuthorization.php
@@ -148,7 +148,7 @@ protected function validateRequest()
     protected function validateIPAccess()
     {
         if (! is_null($this->key()->allowed_ips)) {
-            foreach ($this->key()->allowed_ips as $ip) {
+            foreach (json_decode($this->key()->allowed_ips) as $ip) {
                 if (Range::parse($ip)->contains(new IP($this->request()->ip()))) {
                     return true;
                 }

Original file line number	Diff line number	Diff line change
`@@ -148,7 +148,7 @@ protected function validateRequest()`
`148`	`148`	`protected function validateIPAccess()`
`149`	`149`	`{`
`150`	`150`	`if (! is_null($this->key()->allowed_ips)) {`
`151`		`- foreach ($this->key()->allowed_ips as $ip) {`
	`151`	`+ foreach (json_decode($this->key()->allowed_ips) as $ip) {`
`152`	`152`	`if (Range::parse($ip)->contains(new IP($this->request()->ip()))) {`
`153`	`153`	`return true;`
`154`	`154`	`}`