Allow setting the backup limit via the API; closes pterodactyl#2535

Author: DaneEveritt

app/Http/Requests/Api/Application/Servers/StoreServerRequest.php

@@ -55,6 +55,7 @@ public function rules(): array
             'feature_limits' => 'required|array',
             'feature_limits.databases' => $rules['database_limit'],
             'feature_limits.allocations' => $rules['allocation_limit'],
+            'feature_limits.backups' => $rules['backup_limit'],
 
             // Placeholders for rules added in withValidator() function.
             'allocation.default' => '',
@@ -102,6 +103,7 @@ public function validated()
             'start_on_completion' => array_get($data, 'start_on_completion', false),
             'database_limit' => array_get($data, 'feature_limits.databases'),
             'allocation_limit' => array_get($data, 'feature_limits.allocations'),
+            'backup_limit' => array_get($data, 'feature_limits.backups'),
         ];
     }
 

app/Http/Requests/Api/Application/Servers/UpdateServerBuildConfigurationRequest.php

@@ -47,6 +47,7 @@ public function rules(): array
             'feature_limits' => 'required|array',
             'feature_limits.databases' => $rules['database_limit'],
             'feature_limits.allocations' => $rules['allocation_limit'],
+            'feature_limits.backups' => $rules['backup_limit'],
         ];
     }
 
@@ -60,8 +61,9 @@ public function validated()
         $data = parent::validated();
 
         $data['allocation_id'] = $data['allocation'];
-        $data['database_limit'] = $data['feature_limits']['databases'];
-        $data['allocation_limit'] = $data['feature_limits']['allocations'];
+        $data['database_limit'] = $data['feature_limits']['databases'] ?? null;
+        $data['allocation_limit'] = $data['feature_limits']['allocations'] ?? null;
+        $data['backup_limit'] = $data['feature_limits']['backups'] ?? null;
         unset($data['allocation'], $data['feature_limits']);
 
         // Adjust the limits field to match what is expected by the model.
@@ -90,6 +92,7 @@ public function attributes()
             'remove_allocations.*' => 'allocation to remove',
             'feature_limits.databases' => 'Database Limit',
             'feature_limits.allocations' => 'Allocation Limit',
+            'feature_limits.backups' => 'Backup Limit',
         ];
     }
 

app/Models/Server.php

@@ -122,7 +122,7 @@ class Server extends Model
         'installed' => 'in:0,1,2',
         'database_limit' => 'present|nullable|integer|min:0',
         'allocation_limit' => 'sometimes|nullable|integer|min:0',
-        'backup_limit' => 'present|integer|min:0',
+        'backup_limit' => 'present|nullable|integer|min:0',
     ];
 
     /**

app/Services/Servers/BuildModificationService.php

@@ -101,9 +101,9 @@ public function handle(Server $server, array $data)
             'threads' => array_get($data, 'threads'),
             'disk' => array_get($data, 'disk'),
             'allocation_id' => array_get($data, 'allocation_id'),
-            'database_limit' => array_get($data, 'database_limit', 0),
-            'allocation_limit' => array_get($data, 'allocation_limit', 0),
-            'backup_limit' => array_get($data, 'backup_limit', 0),
+            'database_limit' => array_get($data, 'database_limit', 0) ?? null,
+            'allocation_limit' => array_get($data, 'allocation_limit', 0) ?? null,
+            'backup_limit' => array_get($data, 'backup_limit', 0) ?? null,
         ]);
 
         $updateData = $this->structureService->handle($server);

tests/Integration/Services/Servers/ServerCreationServiceTest.php

@@ -144,9 +144,9 @@ public function testServerIsCreatedWithDeploymentObject()
 
         $this->assertFalse($response->suspended);
         $this->assertTrue($response->oom_disabled);
-        $this->assertEmpty($response->database_limit);
-        $this->assertEmpty($response->allocation_limit);
-        $this->assertEmpty($response->backup_limit);
+        $this->assertSame(0, $response->database_limit);
+        $this->assertSame(0, $response->allocation_limit);
+        $this->assertSame(0, $response->backup_limit);
     }
 
     /**