Update deprecated JSON response creation and unnecessary middleware

Author: DaneEveritt

app/Http/Controllers/Admin/NodeAutoDeployController.php

@@ -74,7 +74,7 @@ public function __invoke(Request $request, Node $node)
             ], ['r_nodes' => 1]);
         }
 
-        return JsonResponse::create([
+        return new JsonResponse([
             'node' => $node->id,
             'token' => $key->identifier . $this->encrypter->decrypt($key->token),
         ]);

app/Http/Controllers/Admin/Nodes/SystemInformationController.php

@@ -35,7 +35,7 @@ public function __invoke(Request $request, Node $node)
     {
         $data = $this->repository->setNode($node)->getSystemInformation();
 
-        return JsonResponse::create([
+        return new JsonResponse([
             'version' => $data['version'] ?? '',
             'system' => [
                 'type' => Str::title($data['os'] ?? 'Unknown'),

app/Http/Controllers/Api/Application/Nodes/NodeConfigurationController.php

@@ -18,6 +18,6 @@ class NodeConfigurationController extends ApplicationApiController
      */
     public function __invoke(GetNodeRequest $request, Node $node)
     {
-        return JsonResponse::create($node->getConfiguration());
+        return new JsonResponse($node->getConfiguration());
     }
 }

app/Http/Controllers/Api/Application/Servers/DatabaseController.php

@@ -78,7 +78,7 @@ public function resetPassword(ServerDatabaseWriteRequest $request, Server $serve
     {
         $this->databasePasswordService->handle($database);
 
-        return JsonResponse::create([], JsonResponse::HTTP_NO_CONTENT);
+        return new JsonResponse([], JsonResponse::HTTP_NO_CONTENT);
     }
 
     /**

app/Http/Controllers/Api/Client/ApiKeyController.php

@@ -102,6 +102,6 @@ public function delete(ClientApiRequest $request, string $identifier)
             throw new NotFoundHttpException();
         }
 
-        return JsonResponse::create([], JsonResponse::HTTP_NO_CONTENT);
+        return new JsonResponse([], JsonResponse::HTTP_NO_CONTENT);
     }
 }

app/Http/Controllers/Api/Remote/Servers/ServerInstallController.php

@@ -45,7 +45,7 @@ public function index(Request $request, string $uuid)
         $server = $this->repository->getByUuid($uuid);
         $egg = $server->egg;
 
-        return JsonResponse::create([
+        return new JsonResponse([
             'container_image' => $egg->copy_script_container,
             'entrypoint' => $egg->copy_script_entry,
             'script' => $egg->copy_script_install,

app/Http/Controllers/Base/LocaleController.php

@@ -31,7 +31,7 @@ public function __invoke(Request $request, string $locale, string $namespace)
     {
         $data = $this->translator->getLoader()->load($locale, str_replace('.', '/', $namespace));
 
-        return JsonResponse::create($data, 200, [
+        return new JsonResponse($data, 200, [
             'E-Tag' => md5(json_encode($data)),
         ]);
     }

app/Http/Kernel.php

@@ -2,11 +2,11 @@
 
 namespace Pterodactyl\Http;
 
+use Illuminate\Http\Middleware\TrustProxies;
 use Pterodactyl\Models\ApiKey;
 use Illuminate\Auth\Middleware\Authorize;
 use Illuminate\Auth\Middleware\Authenticate;
 use Pterodactyl\Http\Middleware\TrimStrings;
-use Pterodactyl\Http\Middleware\TrustProxies;
 use Illuminate\Session\Middleware\StartSession;
 use Pterodactyl\Http\Middleware\EncryptCookies;
 use Pterodactyl\Http\Middleware\Api\IsValidJson;

app/Http/Middleware/TrustProxies.php

@@ -19,7 +19,6 @@
         "ext-zip": "*",
         "aws/aws-sdk-php": "^3.171",
         "doctrine/dbal": "~2.13.9",
-        "fideloper/proxy": "~4.4.1",
         "guzzlehttp/guzzle": "~7.4.2",
         "hashids/hashids": "~4.1.0",
         "laracasts/utilities": "~3.2.1",