Code cleanup to use new findCountWhere function

Author: DaneEveritt

app/Services/Servers/DeletionService.php

@@ -141,13 +141,11 @@ public function handle($server)
         }
 
         $this->database->beginTransaction();
-
         $this->databaseRepository->withColumns('id')->findWhere([['server_id', '=', $server->id]])->each(function ($item) {
             $this->databaseManagementService->delete($item->id);
         });
 
         $this->repository->delete($server->id);
-
         $this->database->commit();
     }
 }

app/Services/Users/DeletionService.php

@@ -78,8 +78,8 @@ public function handle($user)
             $user = $user->id;
         }
 
-        $servers = $this->serverRepository->findWhere([['owner_id', '=', $user]]);
-        if (count($servers) > 0) {
+        $servers = $this->serverRepository->withColumns('id')->findCountWhere([['owner_id', '=', $user]]);
+        if ($servers > 0) {
             throw new DisplayException($this->translator->trans('admin/user.exceptions.user_has_servers'));
         }
 

app/Services/Users/UpdateService.php

@@ -68,8 +68,6 @@ public function handle($id, array $data)
             $data['password'] = $this->hasher->make($data['password']);
         }
 
-        $user = $this->repository->update($id, $data);
-
-        return $user;
+        return $this->repository->update($id, $data);
     }
 }

tests/Unit/Services/Users/DeletionServiceTest.php

@@ -81,7 +81,8 @@ public function setUp()
      */
     public function testUserIsDeletedIfNoServersAreAttachedToAccount()
     {
-        $this->serverRepository->shouldReceive('findWhere')->with([['owner_id', '=', $this->user->id]])->once()->andReturn([]);
+        $this->serverRepository->shouldReceive('withColumns')->with('id')->once()->andReturnSelf()
+            ->shouldReceive('findCountWhere')->with([['owner_id', '=', $this->user->id]])->once()->andReturn(0);
         $this->repository->shouldReceive('delete')->with($this->user->id)->once()->andReturn(true);
 
         $this->assertTrue(
@@ -97,7 +98,8 @@ public function testUserIsDeletedIfNoServersAreAttachedToAccount()
      */
     public function testExceptionIsThrownIfServersAreAttachedToAccount()
     {
-        $this->serverRepository->shouldReceive('findWhere')->with([['owner_id', '=', $this->user->id]])->once()->andReturn(['item']);
+        $this->serverRepository->shouldReceive('withColumns')->with('id')->once()->andReturnSelf()
+            ->shouldReceive('findCountWhere')->with([['owner_id', '=', $this->user->id]])->once()->andReturn(1);
         $this->translator->shouldReceive('trans')->with('admin/user.exceptions.user_has_servers')->once()->andReturnNull();
 
         $this->service->handle($this->user->id);
@@ -108,7 +110,8 @@ public function testExceptionIsThrownIfServersAreAttachedToAccount()
      */
     public function testModelCanBePassedInPlaceOfUserId()
     {
-        $this->serverRepository->shouldReceive('findWhere')->with([['owner_id', '=', $this->user->id]])->once()->andReturn([]);
+        $this->serverRepository->shouldReceive('withColumns')->with('id')->once()->andReturnSelf()
+            ->shouldReceive('findCountWhere')->with([['owner_id', '=', $this->user->id]])->once()->andReturn(0);
         $this->repository->shouldReceive('delete')->with($this->user->id)->once()->andReturn(true);
 
         $this->assertTrue(