Fix some broken tests

Author: DaneEveritt

…Application/AuthenticateIPAccessTest.php …dleware/API/AuthenticateIPAccessTest.phptests/Unit/Http/Middleware/Api/Application/AuthenticateIPAccessTest.php renamed to tests/Unit/Http/Middleware/API/AuthenticateIPAccessTest.php tests/Unit/Http/Middleware/Api/Application/AuthenticateIPAccessTest.php renamed to tests/Unit/Http/Middleware/API/AuthenticateIPAccessTest.php

@@ -1,10 +1,10 @@
 <?php
 
-namespace Tests\Unit\Http\Middleware\Api\Application;
+namespace Tests\Unit\Http\Middleware\API;
 
 use Pterodactyl\Models\ApiKey;
 use Tests\Unit\Http\Middleware\MiddlewareTestCase;
-use Pterodactyl\Http\Middleware\Api\Application\AuthenticateIPAccess;
+use Pterodactyl\Http\Middleware\Api\AuthenticateIPAccess;
 
 class AuthenticateIPAccessTest extends MiddlewareTestCase
 {
@@ -65,7 +65,7 @@ public function testWithInvalidIP()
     /**
      * Return an instance of the middleware to be used when testing.
      *
-     * @return \Pterodactyl\Http\Middleware\Api\Application\AuthenticateIPAccess
+     * @return \Pterodactyl\Http\Middleware\Api\AuthenticateIPAccess
      */
     private function getMiddleware(): AuthenticateIPAccess
     {

…/Api/Application/AuthenticateKeyTest.php …p/Middleware/API/AuthenticateKeyTest.phptests/Unit/Http/Middleware/Api/Application/AuthenticateKeyTest.php renamed to tests/Unit/Http/Middleware/API/AuthenticateKeyTest.php tests/Unit/Http/Middleware/Api/Application/AuthenticateKeyTest.php renamed to tests/Unit/Http/Middleware/API/AuthenticateKeyTest.php

@@ -1,17 +1,17 @@
 <?php
 
-namespace Tests\Unit\Http\Middleware\Api\Application;
+namespace Tests\Unit\Http\Middleware\API;
 
 use Mockery as m;
 use Cake\Chronos\Chronos;
 use Pterodactyl\Models\ApiKey;
 use Illuminate\Auth\AuthManager;
 use Illuminate\Contracts\Encryption\Encrypter;
 use Tests\Unit\Http\Middleware\MiddlewareTestCase;
+use Pterodactyl\Http\Middleware\Api\AuthenticateKey;
 use Symfony\Component\HttpKernel\Exception\HttpException;
 use Pterodactyl\Exceptions\Repository\RecordNotFoundException;
 use Pterodactyl\Contracts\Repository\ApiKeyRepositoryInterface;
-use Pterodactyl\Http\Middleware\Api\Application\AuthenticateKey;
 
 class AuthenticateKeyTest extends MiddlewareTestCase
 {
@@ -51,7 +51,7 @@ public function testMissingBearerTokenThrowsException()
         $this->request->shouldReceive('bearerToken')->withNoArgs()->once()->andReturnNull();
 
         try {
-            $this->getMiddleware()->handle($this->request, $this->getClosureAssertions());
+            $this->getMiddleware()->handle($this->request, $this->getClosureAssertions(), ApiKey::TYPE_APPLICATION);
         } catch (HttpException $exception) {
             $this->assertEquals(401, $exception->getStatusCode());
             $this->assertEquals(['WWW-Authenticate' => 'Bearer'], $exception->getHeaders());
@@ -68,7 +68,7 @@ public function testInvalidIdentifier()
         $this->request->shouldReceive('bearerToken')->withNoArgs()->twice()->andReturn('abcd1234');
         $this->repository->shouldReceive('findFirstWhere')->andThrow(new RecordNotFoundException);
 
-        $this->getMiddleware()->handle($this->request, $this->getClosureAssertions());
+        $this->getMiddleware()->handle($this->request, $this->getClosureAssertions(), ApiKey::TYPE_APPLICATION);
     }
 
     /**
@@ -90,7 +90,30 @@ public function testValidToken()
             'last_used_at' => Chronos::now(),
         ])->once()->andReturnNull();
 
-        $this->getMiddleware()->handle($this->request, $this->getClosureAssertions());
+        $this->getMiddleware()->handle($this->request, $this->getClosureAssertions(), ApiKey::TYPE_APPLICATION);
+        $this->assertEquals($model, $this->request->attributes->get('api_key'));
+    }
+
+    /**
+     * Test that a valid token can continue past the middleware when set as a user token.
+     */
+    public function testValidTokenWithUserKey()
+    {
+        $model = factory(ApiKey::class)->make();
+
+        $this->request->shouldReceive('bearerToken')->withNoArgs()->twice()->andReturn($model->identifier . 'decrypted');
+        $this->repository->shouldReceive('findFirstWhere')->with([
+            ['identifier', '=', $model->identifier],
+            ['key_type', '=', ApiKey::TYPE_ACCOUNT],
+        ])->once()->andReturn($model);
+        $this->encrypter->shouldReceive('decrypt')->with($model->token)->once()->andReturn('decrypted');
+        $this->auth->shouldReceive('guard->loginUsingId')->with($model->user_id)->once()->andReturnNull();
+
+        $this->repository->shouldReceive('withoutFreshModel->update')->with($model->id, [
+            'last_used_at' => Chronos::now(),
+        ])->once()->andReturnNull();
+
+        $this->getMiddleware()->handle($this->request, $this->getClosureAssertions(), ApiKey::TYPE_ACCOUNT);
         $this->assertEquals($model, $this->request->attributes->get('api_key'));
     }
 
@@ -111,13 +134,13 @@ public function testInvalidTokenForIdentifier()
         ])->once()->andReturn($model);
         $this->encrypter->shouldReceive('decrypt')->with($model->token)->once()->andReturn('decrypted');
 
-        $this->getMiddleware()->handle($this->request, $this->getClosureAssertions());
+        $this->getMiddleware()->handle($this->request, $this->getClosureAssertions(), ApiKey::TYPE_APPLICATION);
     }
 
     /**
      * Return an instance of the middleware with mocked dependencies for testing.
      *
-     * @return \Pterodactyl\Http\Middleware\Api\Application\AuthenticateKey
+     * @return \Pterodactyl\Http\Middleware\Api\AuthenticateKey
      */
     private function getMiddleware(): AuthenticateKey
     {

…Api/Application/SetSessionDriverTest.php …/Middleware/API/SetSessionDriverTest.phptests/Unit/Http/Middleware/Api/Application/SetSessionDriverTest.php renamed to tests/Unit/Http/Middleware/API/SetSessionDriverTest.php tests/Unit/Http/Middleware/Api/Application/SetSessionDriverTest.php renamed to tests/Unit/Http/Middleware/API/SetSessionDriverTest.php

@@ -1,13 +1,13 @@
 <?php
 
-namespace Tests\Unit\Http\Middleware\Api\Application;
+namespace Tests\Unit\Http\Middleware\API;
 
 use Mockery as m;
 use Barryvdh\Debugbar\LaravelDebugbar;
 use Illuminate\Contracts\Config\Repository;
 use Illuminate\Contracts\Foundation\Application;
 use Tests\Unit\Http\Middleware\MiddlewareTestCase;
-use Pterodactyl\Http\Middleware\Api\Application\SetSessionDriver;
+use Pterodactyl\Http\Middleware\Api\SetSessionDriver;
 
 class SetSessionDriverTest extends MiddlewareTestCase
 {
@@ -60,7 +60,7 @@ public function testLocalEnvironment()
     /**
      * Return an instance of the middleware with mocked dependencies for testing.
      *
-     * @return \Pterodactyl\Http\Middleware\Api\Application\SetSessionDriver
+     * @return \Pterodactyl\Http\Middleware\Api\SetSessionDriver
      */
     private function getMiddleware(): SetSessionDriver
     {