Allow deleting default allocation and setting new default at the same time.

Author: DaneEveritt

CHANGELOG.md

@@ -15,6 +15,7 @@ This project follows [Semantic Versioning](http://semver.org) guidelines.
 
 ### Changed
 * Deleting a server safely now continues even if the daemon reports a `HTTP/404` missing server error (requires `Daemon@0.4.0-beta.2.1`)
+* Changed behavior when modifying server allocation information. You can now remove the default allocation assuming you assing a new allocation at the same time. Reduces the number of steps to change the default allocation for a server.
 
 ### Added
 * Server listing and view in Admin CP now shows the SFTP username/Docker container name.

app/Repositories/ServerRepository.php

@@ -518,34 +518,42 @@ public function changeBuild($id, array $data)
             }
 
             $newPorts = false;
-            // Remove Assignments
-            if (isset($data['remove_allocations'])) {
-                foreach ($data['remove_allocations'] as $allocation) {
-                    // Can't remove the assigned IP/Port combo
-                    if ((int) $allocation === $server->allocation_id) {
+            $firstNewAllocation = null;
+            // Add Assignments
+            if (isset($data['add_allocations'])) {
+                foreach ($data['add_allocations'] as $allocation) {
+                    $model = Models\Allocation::where('id', $allocation)->whereNull('server_id')->first();
+                    if (! $model) {
                         continue;
                     }
 
                     $newPorts = true;
-                    Models\Allocation::where('id', $allocation)->where('server_id', $server->id)->update([
-                        'server_id' => null,
+                    $firstNewAllocation = (is_null($firstNewAllocation)) ? $model->id : $firstNewAllocation;
+                    $model->update([
+                        'server_id' => $server->id,
                     ]);
                 }
 
                 $server->load('allocations');
             }
 
-            // Add Assignments
-            if (isset($data['add_allocations'])) {
-                foreach ($data['add_allocations'] as $allocation) {
-                    $model = Models\Allocation::where('id', $allocation)->whereNull('server_id')->first();
-                    if (! $model) {
-                        continue;
+            // Remove Assignments
+            if (isset($data['remove_allocations'])) {
+                foreach ($data['remove_allocations'] as $allocation) {
+                    // Can't remove the assigned IP/Port combo
+                    if ((int) $allocation === $server->allocation_id) {
+                        // No New Allocation
+                        if (is_null($firstNewAllocation)) {
+                            continue;
+                        }
+
+                        // New Allocation, set as the default.
+                        $server->allocation_id = $firstNewAllocation;
                     }
 
                     $newPorts = true;
-                    $model->update([
-                        'server_id' => $server->id,
+                    Models\Allocation::where('id', $allocation)->where('server_id', $server->id)->update([
+                        'server_id' => null,
                     ]);
                 }
 

resources/themes/pterodactyl/admin/servers/view/build.blade.php

@@ -130,7 +130,7 @@
                         <div>
                             <select name="remove_allocations[]" class="form-control" multiple id="pRemoveAllocations">
                                 @foreach ($assigned as $assignment)
-                                    <option value="{{ $assignment->id }}" @if($server->allocation_id === $assignment->id)disabled @endif>{{ $assignment->alias }}:{{ $assignment->port }}</option>
+                                    <option value="{{ $assignment->id }}">{{ $assignment->alias }}:{{ $assignment->port }}</option>
                                 @endforeach
                             </select>
                         </div>