Update audit design

Author: DaneEveritt

app/Http/Controllers/Api/Client/Servers/FileController.php

@@ -146,10 +146,8 @@ public function download(GetFileContentsRequest $request, Server $server)
     public function write(WriteFileContentRequest $request, Server $server): JsonResponse
     {
         $server->audit(AuditLog::ACTION_SERVER_FILESYSTEM_WRITE, function (AuditLog $audit, Server $server) use ($request) {
-            $audit->metadata = [
-                'file' => $request->get('file'),
-                'sub_action' => 'write_content',
-            ];
+            $audit->subaction = 'write_content';
+            $audit->metadata = ['file' => $request->get('file')];
 
             $this->fileRepository
                 ->setServer($server)
@@ -171,10 +169,8 @@ public function write(WriteFileContentRequest $request, Server $server): JsonRes
     public function create(CreateFolderRequest $request, Server $server): JsonResponse
     {
         $server->audit(AuditLog::ACTION_SERVER_FILESYSTEM_WRITE, function (AuditLog $audit, Server $server) use ($request) {
-            $audit->metadata = [
-                'file' => $request->input('root', '/') . $request->input('name'),
-                'sub_action' => 'create_folder',
-            ];
+            $audit->subaction = 'create_folder';
+            $audit->metadata = ['file' => $request->input('root', '/') . $request->input('name')];
 
             $this->fileRepository
                 ->setServer($server)
@@ -218,10 +214,9 @@ public function rename(RenameFileRequest $request, Server $server): JsonResponse
     public function copy(CopyFileRequest $request, Server $server): JsonResponse
     {
         $server->audit(AuditLog::ACTION_SERVER_FILESYSTEM_WRITE, function (AuditLog $audit, Server $server) use ($request) {
-            $audit->metadata = [
-                'file' => $request->input('location'),
-                'sub_action' => 'copy_file',
-            ];
+            $audit->subaction = 'copy_file';
+            $audit->metadata = ['file' => $request->input('location')];
+
             $this->fileRepository
                 ->setServer($server)
                 ->copyFile($request->input('location'));

app/Models/AuditLog.php

@@ -13,6 +13,7 @@
  * @property int|null $user_id
  * @property int|null $server_id
  * @property string $action
+ * @property string|null $subaction
  * @property array $device
  * @property array $metadata
  * @property \Carbon\CarbonImmutable $created_at
@@ -49,7 +50,8 @@ class AuditLog extends Model
      */
     public static $validationRules = [
         'uuid' => 'required|uuid',
-        'action' => 'required|string',
+        'action' => 'required|string|max:191',
+        'subaction' => 'nullable|string|max:191',
         'device' => 'array',
         'device.ip_address' => 'ip',
         'device.user_agent' => 'string',

database/migrations/2021_01_17_102401_create_audit_logs_table.php

@@ -17,12 +17,16 @@ public function up()
             $table->id();
             $table->char('uuid', 36);
             $table->boolean('is_system')->default(false);
-            $table->bigInteger('user_id')->nullable();
-            $table->bigInteger('server_id')->nullable();
+            $table->unsignedInteger('user_id')->nullable();
+            $table->unsignedInteger('server_id')->nullable();
             $table->string('action');
+            $table->string('subaction')->nullable();
             $table->json('device');
             $table->json('metadata');
             $table->timestamp('created_at', 0);
+
+            $table->foreign('user_id')->references('id')->on('users')->onDelete('set null');
+            $table->foreign('server_id')->references('id')->on('servers')->onDelete('cascade');
         });
     }