Set notes to null when assigning allocation; ref pterodactyl#2553

Author: DaneEveritt

app/Services/Servers/BuildModificationService.php

@@ -115,7 +115,7 @@ private function processAllocations(Server $server, array &$data)
             // one to reset the default allocation to.
             $freshlyAllocated = $query->pluck('id')->first();
 
-            $query->update(['server_id' => $server->id]);
+            $query->update(['server_id' => $server->id, 'notes' => null]);
         }
 
         if (! empty($data['remove_allocations'])) {

tests/Integration/Services/Servers/BuildModificationServiceTest.php

@@ -39,7 +39,7 @@ public function testAllocationsCanBeModifiedForTheServer()
         $server2 = $this->createServerModel();
 
         /** @var \Pterodactyl\Models\Allocation[] $allocations */
-        $allocations = factory(Allocation::class)->times(4)->create(['node_id' => $server->node_id]);
+        $allocations = factory(Allocation::class)->times(4)->create(['node_id' => $server->node_id, 'notes' => 'Random notes']);
 
         $initialAllocationId = $server->allocation_id;
         $allocations[0]->update(['server_id' => $server->id, 'notes' => 'Test notes']);
@@ -66,6 +66,7 @@ public function testAllocationsCanBeModifiedForTheServer()
         // Only one allocation should exist for this server now.
         $this->assertCount(1, $response->allocations);
         $this->assertSame($allocations[1]->id, $response->allocation_id);
+        $this->assertNull($response->allocation->notes);
 
         // These two allocations should not have been touched.
         $this->assertDatabaseHas('allocations', ['id' => $allocations[2]->id, 'server_id' => $server2->id]);