Correctly validate description for API keys to match model expectations; closes pterodactyl#2457

Author: DaneEveritt

app/Http/Requests/Api/Client/Account/StoreApiKeyRequest.php

@@ -2,6 +2,7 @@
 
 namespace Pterodactyl\Http\Requests\Api\Client\Account;
 
+use Pterodactyl\Models\ApiKey;
 use Pterodactyl\Http\Requests\Api\Client\ClientApiRequest;
 
 class StoreApiKeyRequest extends ClientApiRequest
@@ -11,9 +12,11 @@ class StoreApiKeyRequest extends ClientApiRequest
      */
     public function rules(): array
     {
+        $rules = ApiKey::getRules();
+
         return [
-            'description' => 'required|string|min:4',
-            'allowed_ips' => 'array',
+            'description' => $rules['memo'],
+            'allowed_ips' => $rules['allowed_ips'],
             'allowed_ips.*' => 'ip',
         ];
     }

tests/Integration/Api/Client/ApiKeyControllerTest.php

@@ -121,6 +121,8 @@ public function testNoMoreThanFiveApiKeysCanBeCreatedForAnAccount()
 
     /**
      * Test that a bad request results in a validation error being returned by the API.
+     *
+     * @see https://github.com/pterodactyl/panel/issues/2457
      */
     public function testValidationErrorIsReturnedForBadRequests()
     {
@@ -135,6 +137,15 @@ public function testValidationErrorIsReturnedForBadRequests()
         $response->assertStatus(Response::HTTP_UNPROCESSABLE_ENTITY);
         $response->assertJsonPath('errors.0.meta.rule', 'required');
         $response->assertJsonPath('errors.0.detail', 'The description field is required.');
+
+        $response = $this->actingAs($user)->postJson('/api/client/account/api-keys', [
+            'description' => str_repeat('a', 501),
+            'allowed_ips' => ['127.0.0.1'],
+        ]);
+
+        $response->assertStatus(Response::HTTP_UNPROCESSABLE_ENTITY);
+        $response->assertJsonPath('errors.0.meta.rule', 'max');
+        $response->assertJsonPath('errors.0.detail', 'The description may not be greater than 500 characters.');
     }
 
     /**