Fix server startup dropdown for egg being incorrect, fixes pterodactyl#778

Author: DaneEveritt

CHANGELOG.md

@@ -6,6 +6,7 @@ This project follows [Semantic Versioning](http://semver.org) guidelines.
 ## v0.7.0-beta.3 (Derelict Dermodactylus)
 ### Fixed
 * `[beta.2]` — Fixes a bug that would cause an endless exception message stream in the console when attemping to setup environment settings in certain instances.
+* `[beta.2]` — Fixes a bug causing the dropdown menu for a server's egg to display the wrong selected value.
 
 ## v0.7.0-beta.2 (Derelict Dermodactylus)
 ### Fixed

app/Http/Controllers/Admin/ServersController.php

@@ -319,21 +319,22 @@ public function viewBuild($server)
     /**
      * Display startup configuration page for a server.
      *
-     * @param int $server
+     * @param \Pterodactyl\Models\Server $server
      * @return \Illuminate\View\View
      *
      * @throws \Pterodactyl\Exceptions\Repository\RecordNotFoundException
      */
-    public function viewStartup($server)
+    public function viewStartup(Server $server)
     {
-        $parameters = $this->repository->getVariablesWithValues($server, true);
+        $parameters = $this->repository->getVariablesWithValues($server->id, true);
         if (! $parameters->server->installed) {
             abort(404);
         }
 
         $nests = $this->nestRepository->getWithEggs();
 
         Javascript::put([
+            'server' => $server,
             'nests' => $nests->map(function ($item) {
                 return array_merge($item->toArray(), [
                     'eggs' => $item->eggs->keyBy('id')->toArray(),

resources/lang/en/admin/server.php

@@ -16,7 +16,7 @@
         'default_allocation_not_found' => 'The requested default allocation was not found in this server\'s allocations.',
     ],
     'alerts' => [
-        'startup_changed' => 'The startup configuration for this server has been updated. If this server\'s service or option was changed a reinstall will be occuring now.',
+        'startup_changed' => 'The startup configuration for this server has been updated. If this server\'s nest or egg was changed a reinstall will be occuring now.',
         'server_deleted' => 'Server has successfully been deleted from the system.',
         'server_created' => 'Server was successfully created on the panel. Please allow the daemon a few minutes to completely install this server.',
         'build_updated' => 'The build details for this server have been updated. Some changes may require a restart to take effect.',

resources/themes/pterodactyl/admin/servers/view/startup.blade.php

@@ -148,7 +148,7 @@
                         text: item.name,
                     };
                 }),
-            }).change();
+            }).val(Pterodactyl.server.egg_id).change();
         });
 
         $('#pEggId').on('change', function (event) {
@@ -157,8 +157,8 @@
 
             $('#setDefaultImage').html(_.get(objectChain, 'docker_image', 'undefined'));
             $('#pDockerImage').val(_.get(objectChain, 'docker_image', 'undefined'));
-            if (objectChain.id === parseInt('{{ $server->egg_id }}')) {
-                $('#pDockerImage').val('{{ $server->image }}');
+            if (objectChain.id === parseInt(Pterodactyl.server.egg_id)) {
+                $('#pDockerImage').val(Pterodactyl.server.image);
             }
 
             if (!_.get(objectChain, 'startup', false)) {
@@ -178,9 +178,9 @@
                 ),
             });
 
-            @if(! is_null($server->pack_id))
-                $('#pPackId').val({{ $server->pack_id }});
-            @endif
+            if (Pterodactyl.server.pack_id !== null) {
+                $('#pPackId').val(Pterodactyl.server.pack_id);
+            }
 
             $('#appendVariablesTo').html('');
             $.each(_.get(objectChain, 'variables', []), function (i, item) {