omi/backend/tests/unit/test_apps_create_app_json.py at main · ghzhost/omi · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
"""App/persona multipart JSON form contract tests."""

import pytest
from fastapi import HTTPException

from utils.request_validation import (
    backfill_app_home_url_from_auth_steps,
    normalize_required_webhook_url,
    parse_form_json,
)


def test_create_app_invalid_json_returns_422_before_handler_io():
    with pytest.raises(HTTPException) as exc_info:
        parse_form_json(dict, 'this is not json', 'app_data')

    assert exc_info.value.status_code == 422
    assert 'app_data' in exc_info.value.detail


@pytest.mark.parametrize('payload', ['[1, 2, 3]', '"a string"', '42'])
def test_create_app_non_object_json_returns_422_before_handler_io(payload):
    with pytest.raises(HTTPException) as exc_info:
        parse_form_json(dict, payload, 'app_data')

    assert exc_info.value.status_code == 422
    assert 'app_data' in exc_info.value.detail


@pytest.mark.parametrize('webhook_url', ['', '   ', None, 123])
def test_trigger_webhook_url_must_be_nonblank_string(webhook_url):
    external_integration = {'webhook_url': webhook_url}

    with pytest.raises(HTTPException) as exc_info:
        normalize_required_webhook_url(external_integration)

    assert exc_info.value.status_code == 422


def test_trigger_webhook_url_is_trimmed_after_validation():
    external_integration = {'webhook_url': '  https://example.com/webhook  '}

    normalize_required_webhook_url(external_integration)

    assert external_integration['webhook_url'] == 'https://example.com/webhook'


@pytest.mark.parametrize('auth_steps', ['not-a-list', {'url': 'https://example.com'}, [None], ['bad'], [{}]])
def test_auth_steps_app_home_backfill_rejects_malformed_single_step(auth_steps):
    external_integration = {'auth_steps': auth_steps}

    with pytest.raises(HTTPException) as exc_info:
        backfill_app_home_url_from_auth_steps(external_integration)

    assert exc_info.value.status_code == 422


def test_auth_steps_app_home_backfill_accepts_single_url_step():
    external_integration = {'auth_steps': [{'url': 'https://example.com/oauth'}]}

    backfill_app_home_url_from_auth_steps(external_integration)

    assert external_integration['app_home_url'] == 'https://example.com/oauth'