forked from BasedHardware/omi
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathmultipart_401_retry_test.dart
More file actions
368 lines (325 loc) · 10.9 KB
/
Copy pathmultipart_401_retry_test.dart
File metadata and controls
368 lines (325 loc) · 10.9 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
import 'dart:async';
import 'dart:io';
import 'package:flutter_test/flutter_test.dart';
import 'package:http/http.dart' as http;
import 'package:path/path.dart' as path;
/// Tests multipart request rebuilding around a 401 replay. Typed auth policy
/// itself is covered against production code in authenticated_request_401_test.
///
/// The production code in shared.dart uses singletons (HttpPoolManager,
/// SharedPreferencesUtil, AuthService) that aren't injectable, so this
/// test exercises the exact same branching logic via a minimal abstraction
/// that mirrors the production flow.
/// Abstracts the dependencies used by the multipart 401 retry logic.
class AuthRetryDeps {
final Future<http.StreamedResponse> Function(http.BaseRequest) sendRequest;
final Future<String> Function() refreshToken;
final Future<void> Function() signOut;
AuthRetryDeps({required this.sendRequest, required this.refreshToken, required this.signOut});
}
/// Builds a fresh MultipartRequest (mirrors _buildMultipartRequest in shared.dart).
/// Streams are single-use, so we must rebuild for each send attempt.
Future<http.MultipartRequest> buildMultipartRequest({
required String url,
required List<File> files,
required Map<String, String> headers,
required Map<String, String> fields,
required String fileFieldName,
required String method,
}) async {
var request = http.MultipartRequest(method, Uri.parse(url));
request.headers.addAll(headers);
request.fields.addAll(fields);
for (var file in files) {
var stream = http.ByteStream(file.openRead());
var length = await file.length();
var multipartFile = http.MultipartFile(fileFieldName, stream, length, filename: path.basename(file.path));
request.files.add(multipartFile);
}
return request;
}
/// Models the multipart request-rebuild portion of makeMultipartApiCall().
/// Returns the final http.Response and whether signOut was called.
Future<http.Response> makeMultipartApiCallWithRetry({
required String url,
required List<File> files,
required Map<String, String> headers,
required Map<String, String> fields,
required String fileFieldName,
required String method,
required bool requireAuthCheck,
required AuthRetryDeps deps,
}) async {
var request = await buildMultipartRequest(
url: url,
files: files,
headers: headers,
fields: fields,
fileFieldName: fileFieldName,
method: method,
);
var streamedResponse = await deps.sendRequest(request);
var response = await http.Response.fromStream(streamedResponse);
if (requireAuthCheck && response.statusCode == 401) {
// Refresh token
String newToken = await deps.refreshToken();
if (newToken.isNotEmpty) {
// Rebuild request (streams are consumed) and retry
request = await buildMultipartRequest(
url: url,
files: files,
headers: {...headers, 'Authorization': 'Bearer $newToken'},
fields: fields,
fileFieldName: fileFieldName,
method: method,
);
streamedResponse = await deps.sendRequest(request);
response = await http.Response.fromStream(streamedResponse);
if (response.statusCode == 401) {
await deps.signOut();
}
}
}
return response;
}
void main() {
late Directory tempDir;
late File testFile;
setUp(() {
tempDir = Directory.systemTemp.createTempSync('multipart_401_test_');
testFile = File('${tempDir.path}/test.txt')..writeAsStringSync('test content');
});
tearDown(() {
tempDir.deleteSync(recursive: true);
});
http.StreamedResponse mockStreamedResponse(int statusCode, {String body = ''}) {
return http.StreamedResponse(Stream.value(body.codeUnits), statusCode);
}
group('makeMultipartApiCall 401 retry logic', () {
test('non-401 response returns directly without refresh or signout', () async {
int sendCount = 0;
bool refreshCalled = false;
bool signOutCalled = false;
final deps = AuthRetryDeps(
sendRequest: (_) async {
sendCount++;
return mockStreamedResponse(200, body: 'ok');
},
refreshToken: () async {
refreshCalled = true;
return 'new-token';
},
signOut: () async {
signOutCalled = true;
},
);
final response = await makeMultipartApiCallWithRetry(
url: 'https://api.omi.me/v1/sync-local-files',
files: [testFile],
headers: {'Authorization': 'Bearer old-token'},
fields: {},
fileFieldName: 'files',
method: 'POST',
requireAuthCheck: true,
deps: deps,
);
expect(response.statusCode, 200);
expect(sendCount, 1);
expect(refreshCalled, false);
expect(signOutCalled, false);
});
test('401 → refresh succeeds → retry succeeds (200)', () async {
int sendCount = 0;
bool refreshCalled = false;
bool signOutCalled = false;
final deps = AuthRetryDeps(
sendRequest: (_) async {
sendCount++;
if (sendCount == 1) {
return mockStreamedResponse(401);
}
return mockStreamedResponse(200, body: 'ok');
},
refreshToken: () async {
refreshCalled = true;
return 'refreshed-token';
},
signOut: () async {
signOutCalled = true;
},
);
final response = await makeMultipartApiCallWithRetry(
url: 'https://api.omi.me/v1/sync-local-files',
files: [testFile],
headers: {'Authorization': 'Bearer expired-token'},
fields: {},
fileFieldName: 'files',
method: 'POST',
requireAuthCheck: true,
deps: deps,
);
expect(response.statusCode, 200);
expect(sendCount, 2);
expect(refreshCalled, true);
expect(signOutCalled, false);
});
test('401 → refresh succeeds → retry still 401 → signs out', () async {
int sendCount = 0;
bool refreshCalled = false;
bool signOutCalled = false;
final deps = AuthRetryDeps(
sendRequest: (_) async {
sendCount++;
return mockStreamedResponse(401);
},
refreshToken: () async {
refreshCalled = true;
return 'refreshed-but-still-invalid';
},
signOut: () async {
signOutCalled = true;
},
);
final response = await makeMultipartApiCallWithRetry(
url: 'https://api.omi.me/v1/sync-local-files',
files: [testFile],
headers: {'Authorization': 'Bearer expired-token'},
fields: {},
fileFieldName: 'files',
method: 'POST',
requireAuthCheck: true,
deps: deps,
);
expect(response.statusCode, 401);
expect(sendCount, 2);
expect(refreshCalled, true);
expect(signOutCalled, true);
});
test('401 → one transient empty refresh → does not sign out or replay', () async {
int sendCount = 0;
bool refreshCalled = false;
bool signOutCalled = false;
final deps = AuthRetryDeps(
sendRequest: (_) async {
sendCount++;
return mockStreamedResponse(401);
},
refreshToken: () async {
refreshCalled = true;
return ''; // empty = refresh failed
},
signOut: () async {
signOutCalled = true;
},
);
final response = await makeMultipartApiCallWithRetry(
url: 'https://api.omi.me/v1/sync-local-files',
files: [testFile],
headers: {'Authorization': 'Bearer expired-token'},
fields: {},
fileFieldName: 'files',
method: 'POST',
requireAuthCheck: true,
deps: deps,
);
expect(response.statusCode, 401);
expect(sendCount, 1); // no retry when refresh fails
expect(refreshCalled, true);
expect(signOutCalled, false, reason: 'a single unavailable refresh is not terminal');
});
test('401 with requireAuthCheck=false returns 401 without retry', () async {
int sendCount = 0;
bool refreshCalled = false;
bool signOutCalled = false;
final deps = AuthRetryDeps(
sendRequest: (_) async {
sendCount++;
return mockStreamedResponse(401);
},
refreshToken: () async {
refreshCalled = true;
return 'new-token';
},
signOut: () async {
signOutCalled = true;
},
);
final response = await makeMultipartApiCallWithRetry(
url: 'https://external.api.com/upload',
files: [testFile],
headers: {},
fields: {},
fileFieldName: 'files',
method: 'POST',
requireAuthCheck: false, // external URL, no auth check
deps: deps,
);
expect(response.statusCode, 401);
expect(sendCount, 1);
expect(refreshCalled, false);
expect(signOutCalled, false);
});
test('request is rebuilt for retry (fresh stream)', () async {
int sendCount = 0;
final requestUrls = <String>[];
final requestHeaders = <Map<String, String>>[];
final deps = AuthRetryDeps(
sendRequest: (request) async {
sendCount++;
requestUrls.add(request.url.toString());
requestHeaders.add(Map.from(request.headers));
if (sendCount == 1) {
return mockStreamedResponse(401);
}
return mockStreamedResponse(200, body: 'ok');
},
refreshToken: () async => 'new-token',
signOut: () async {},
);
final response = await makeMultipartApiCallWithRetry(
url: 'https://api.omi.me/v1/sync-local-files',
files: [testFile],
headers: {'Authorization': 'Bearer old-token'},
fields: {'key': 'value'},
fileFieldName: 'files',
method: 'POST',
requireAuthCheck: true,
deps: deps,
);
expect(response.statusCode, 200);
expect(sendCount, 2);
// Both requests hit the same URL
expect(requestUrls[0], requestUrls[1]);
// Second request has refreshed token
expect(requestHeaders[1]['Authorization'], 'Bearer new-token');
});
test('500 response does not trigger auth retry', () async {
int sendCount = 0;
bool refreshCalled = false;
final deps = AuthRetryDeps(
sendRequest: (_) async {
sendCount++;
return mockStreamedResponse(500, body: 'server error');
},
refreshToken: () async {
refreshCalled = true;
return 'new-token';
},
signOut: () async {},
);
final response = await makeMultipartApiCallWithRetry(
url: 'https://api.omi.me/v1/sync-local-files',
files: [testFile],
headers: {'Authorization': 'Bearer valid-token'},
fields: {},
fileFieldName: 'files',
method: 'POST',
requireAuthCheck: true,
deps: deps,
);
expect(response.statusCode, 500);
expect(sendCount, 1);
expect(refreshCalled, false);
});
});
}