gtfs-scorecard/pipeline/tests/test_identity.py at main · ghzhost/gtfs-scorecard · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
"""Tests for the organization/feed identity ledger."""

from __future__ import annotations

import pytest

from scorecard_pipeline.config import Agency
from scorecard_pipeline.identity import (
    build_identity_ledger,
    normalized_feed_url,
    normalized_mdb_id,
    resolve_published_agency_name,
)


def _agency(agency_id: str, url: str, **kwargs: object) -> Agency:
    return Agency(
        id=agency_id,
        name=agency_id,
        static_gtfs_url=url,
        **kwargs,  # type: ignore[arg-type]
    )


def test_published_agency_name_prefers_registry_then_artifact_then_id() -> None:
    assert (
        resolve_published_agency_name(
            "demo",
            registry_name="Curated Demo Transit",
            artifact_name="Old Export Name",
        )
        == "Curated Demo Transit"
    )
    assert (
        resolve_published_agency_name("demo", artifact_name="Old Export Name") == "Old Export Name"
    )
    assert resolve_published_agency_name("demo") == "demo"


@pytest.mark.parametrize(
    ("mdb_id", "expected"),
    [
        ("123", "mdb-123"),
        ("mdb-123", "mdb-123"),
        ("000123", "mdb-123"),
        ("mdb-000123", "mdb-123"),
        ("0", "mdb-0"),
        ("mdb-000", "mdb-0"),
    ],
)
def test_normalized_mdb_id_canonicalizes_legacy_numeric_forms(mdb_id: str, expected: str) -> None:
    assert normalized_mdb_id(mdb_id) == expected


@pytest.mark.parametrize(
    "mdb_id",
    [
        "",
        "tdg-123",
        "f-9q9-example",
        "mdb-custom",
        "MDB-123",
        "\uff11\uff12\uff13",
        " 123 ",
    ],
)
def test_normalized_mdb_id_preserves_nonlegacy_ids(mdb_id: str) -> None:
    assert normalized_mdb_id(mdb_id) == mdb_id


def test_normalized_feed_url_ignores_scheme_and_default_port() -> None:
    assert normalized_feed_url("http://Example.org:80/feed.zip") == "example.org/feed.zip"
    assert normalized_feed_url("https://example.org:443/feed.zip/") == "example.org/feed.zip"


def test_normalized_feed_url_preserves_scheme_mismatched_ports() -> None:
    assert normalized_feed_url("http://example.org:443/feed.zip") == "example.org:443/feed.zip"
    assert normalized_feed_url("https://example.org:80/feed.zip") == "example.org:80/feed.zip"


@pytest.mark.parametrize(
    "url",
    [
        "javascript:alert(1)",
        "ftp://example.org/feed.zip",
        "example.org/feed.zip",
        "https:///feed.zip",
        "https://user@example.org/feed.zip",
        "https://user:secret@example.org/feed.zip",
        "https://@example.org/feed.zip",
    ],
)
def test_normalized_feed_url_rejects_non_http_hostless_and_userinfo_urls(url: str) -> None:
    assert normalized_feed_url(url) == ""


def test_normalized_feed_url_skips_invalid_external_catalog_ports() -> None:
    assert normalized_feed_url("https://example.org:not-a-port/feed.zip") == ""
    assert normalized_feed_url("https://example.org:99999/feed.zip") == ""


@pytest.mark.parametrize(
    "url",
    [
        "https://[::1/feed.zip",
        "https://example.org\uff0f@evil.example/feed.zip",
    ],
)
def test_normalized_feed_url_skips_malformed_external_catalog_netlocs(url: str) -> None:
    assert normalized_feed_url(url) == ""


def test_identity_ledger_keeps_denominators_separate() -> None:
    agencies = [
        _agency(
            "bus",
            "https://example.org/feed.zip",
            mdb_id="mdb-1",
            organization_id="demo-transit",
            is_official=True,
        ),
        _agency(
            "rail",
            "https://example.org/rail.zip",
            mdb_id="mdb-2",
            organization_id="demo-transit",
        ),
        _agency(
            "old",
            "http://example.org/feed.zip",
            mdb_id="mdb-1",
            alias_of="bus",
            feed_status="deprecated",
        ),
    ]

    ledger = build_identity_ledger(agencies)
    assert ledger["configured_feed_records"] == 3
    assert ledger["active_feed_records"] == 2
    assert ledger["canonical_feed_records"] == 2
    assert ledger["active_canonical_feed_records"] == 2
    assert ledger["distinct_organizations"] == 1
    assert ledger["distinct_organization_keys"] == 1
    assert ledger["provisional_organization_keys"] == 0
    assert ledger["alias_records"] == 1
    assert ledger["official_sources"] == 1
    assert ledger["unresolved_duplicate_mdb_ids"] == []
    assert ledger["unresolved_duplicate_feed_urls"] == []


def test_identity_ledger_reports_unresolved_canonical_duplicates() -> None:
    ledger = build_identity_ledger(
        [
            _agency("one", "http://example.org/feed.zip", mdb_id="same"),
            _agency("two", "https://example.org/feed.zip", mdb_id="same"),
        ]
    )

    assert ledger["unresolved_duplicate_mdb_ids"] == [{"key": "same", "ids": ["one", "two"]}]
    assert ledger["unresolved_duplicate_feed_urls"] == [
        {"key": "example.org/feed.zip", "ids": ["one", "two"]}
    ]
    assert ledger["provisional_organization_keys"] == 2


def test_identity_ledger_groups_equivalent_legacy_mdb_ids() -> None:
    ledger = build_identity_ledger(
        [
            _agency("bare", "https://example.org/bare.zip", mdb_id="00123"),
            _agency("prefixed", "https://example.org/prefixed.zip", mdb_id="mdb-123"),
        ]
    )

    assert ledger["unresolved_duplicate_mdb_ids"] == [
        {"key": "mdb-123", "ids": ["bare", "prefixed"]}
    ]