Skip to content

Commit f3ff1e4

Browse files
author
Marius Cramer
committed
Merge branch 'master' into 'master'
check sql-mode during install and setup See merge request !206
2 parents a9b3252 + 670d377 commit f3ff1e4

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

install/lib/installer_base.lib.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -181,6 +181,11 @@ public function force_configure_app($service) {
181181
public function configure_database() {
182182
global $conf;
183183

184+
//* check sql-mode
185+
$check_sql_mode = $this->db->queryOneRecord("SELECT @@sql_mode");
186+
187+
if ($check_sql_mode['@@sql_mode'] != '' && $check_sql_mode['@@sql_mode'] != 'NO_ENGINE_SUBSTITUTION') die('Wrong SQL-mode. You should use NO_ENGINE_SUBSTITUTION');
188+
184189
//** Create the database
185190
if(!$this->db->query('CREATE DATABASE IF NOT EXISTS ?? DEFAULT CHARACTER SET ?', $conf['mysql']['database'], $conf['mysql']['charset'])) {
186191
$this->error('Unable to create MySQL database: '.$conf['mysql']['database'].'.');

install/lib/update.lib.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,10 @@ function checkDbHealth() {
123123
function updateDbAndIni() {
124124
global $inst, $conf;
125125

126+
//* check sql-mode
127+
$check_sql_mode = $inst->db->queryOneRecord("SELECT @@sql_mode");
128+
if ($check_sql_mode['@@sql_mode'] != '' && $check_sql_mode['@@sql_mode'] != 'NO_ENGINE_SUBSTITUTION') die('Wrong SQL-mode. You should use NO_ENGINE_SUBSTITUTION');
129+
126130
//* Update $conf array with values from the server.ini that shall be preserved
127131
$tmp = $inst->db->queryOneRecord("SELECT * FROM ?? WHERE server_id = ?", $conf["mysql"]["database"] . '.server', $conf['server_id']);
128132
$ini_array = ini_to_array(stripslashes($tmp['config']));

0 commit comments

Comments
 (0)