Fixed: username in sys_user table gets not updated when the username in client form is changed.

Author: tbrehm

interface/lib/classes/tform.inc.php

@@ -906,8 +906,8 @@ function datalogSave($action,$primary_id, $record_old, $record_new) {
                         $escape = '`';
                 }
 
-                $diffrec = array();
-				
+                $this->diffrec = array();
+				/*
                 if(is_array($record_new) && count($record_new) > 0) {
                         foreach($record_new as $key => $val) {
                                 if(@$record_old[$key] != $val) {
@@ -926,7 +926,7 @@ function datalogSave($action,$primary_id, $record_old, $record_new) {
                         }
                 }
 				$this->diffrec = $diffrec;
-				
+				*/
 
 				// Full diff records for ISPConfig, they have a different format then the simple diffrec
 				$diffrec_full = array();
@@ -938,6 +938,8 @@ function datalogSave($action,$primary_id, $record_old, $record_new) {
                                     // Record has changed
 									$diffrec_full['old'][$key] = $val;
 									$diffrec_full['new'][$key] = $record_new[$key];
+									$this->diffrec[$key] = array(	'new' => $record_new[$key],
+                                                               		'old' => $val);
                                 } else {
 									$diffrec_full['old'][$key] = $val;
 									$diffrec_full['new'][$key] = $val;
@@ -949,13 +951,16 @@ function datalogSave($action,$primary_id, $record_old, $record_new) {
                                     // Record has changed
 									$diffrec_full['new'][$key] = $val;
 									$diffrec_full['old'][$key] = $record_old[$key];
+									$this->diffrec[$key] = array(	'old' => @$record_old[$key],
+                                                               		'new' => $val);
                                 } else {
 									$diffrec_full['new'][$key] = $val;
 									$diffrec_full['old'][$key] = $val;
 								}
                         }
                 }
 
+				//$this->diffrec = $diffrec;
 				// Insert the server_id, if the record has a server_id
 				$server_id = (isset($record_old["server_id"]) && $record_old["server_id"] > 0)?$record_old["server_id"]:0;
 				if(isset($record_new["server_id"])) $server_id = $record_new["server_id"];

interface/lib/classes/tform_actions.inc.php

@@ -114,8 +114,8 @@ function onUpdate() {
                         foreach($this->plugins as $plugin) {
                                 $plugin->onInsert();
                         }
-
-                        $this->onAfterUpdate();
+						
+						$this->onAfterUpdate();
 
 						// Write data history (sys_datalog)
 						if($app->tform->formDef['db_history'] == 'yes') {

interface/web/client/client_edit.php

@@ -132,7 +132,7 @@ function onAfterUpdate() {
 		global $app;
 
 		// username changed
-		if(isset($app->tform->diffrec['username'])) {
+		if($this->oldDataRecord['username'] != $this->dataRecord['username']) {
 			$username = mysql_real_escape_string($this->dataRecord["username"]);
 			$client_id = $this->id;
 			$sql = "UPDATE sys_user SET username = '$username' WHERE client_id = $client_id";