Skip to content

Commit f2ea1ac

Browse files
committed
Added: FS#696 - Make the allow override settings configurable per server and website
1 parent 5734aa4 commit f2ea1ac

File tree

8 files changed

+28
-9
lines changed

8 files changed

+28
-9
lines changed

install/sql/ispconfig3.sql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1028,6 +1028,7 @@ CREATE TABLE `web_domain` (
10281028
`ssl_bundle` mediumtext NULL,
10291029
`ssl_action` varchar(16) NULL,
10301030
`stats_password` varchar(255) default NULL,
1031+
`allow_override` varchar(32) NOT NULL default 'All',
10311032
`apache_directives` text,
10321033
`active` enum('n','y') NOT NULL default 'y',
10331034
PRIMARY KEY (`domain_id`)

interface/web/admin/lib/lang/en.lng

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ $wb['Add group'] = 'Add group';
2222
$wb['Edit group'] = 'Edit group';
2323
$wb['Groups'] = 'Groups';
2424
$wb['Edit server'] = 'Edit server';
25-
$wb['Edit Server IP'] = 'Edit Server IP';
25+
$wb['Edit Server IP'] = 'Server IP addresses';
2626
$wb['Servers'] = 'Servers';
2727
$wb['Sync. Now'] = 'Sync. Now';
2828
$wb['DB Sync.'] = 'DB Sync.';
@@ -33,5 +33,6 @@ $wb['Import'] = 'Import';
3333
$wb['Language Editor'] = 'Language Editor';
3434
$wb['Software'] = 'Software';
3535
$wb['Repositories'] = 'Repositories';
36+
$wb['Server Services'] = 'Server Services';
3637

3738
?>

interface/web/admin/lib/module.conf.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
$module['name'] = 'admin';
66
$module['title'] = 'System';
77
$module['template'] = 'module.tpl.htm';
8-
$module['startpage'] = 'admin/users_list.php';
8+
$module['startpage'] = 'admin/server_list.php';
99
$module['tab_width'] = '60';
1010

1111

@@ -47,7 +47,7 @@
4747
'target' => 'content',
4848
'link' => 'admin/server_edit.php');
4949
*/
50-
$items[] = array( 'title' => 'Edit server',
50+
$items[] = array( 'title' => 'Server Services',
5151
'target' => 'content',
5252
'link' => 'admin/server_list.php');
5353

interface/web/sites/form/web_domain.tform.php

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -399,6 +399,17 @@
399399
'width' => '30',
400400
'maxlength' => '255'
401401
),
402+
'allow_override' => array (
403+
'datatype' => 'VARCHAR',
404+
'formtype' => 'TEXT',
405+
'validators' => array ( 0 => array ( 'type' => 'NOTEMPTY',
406+
'errmsg'=> 'documentroot_error_empty'),
407+
),
408+
'default' => 'All',
409+
'value' => '',
410+
'width' => '30',
411+
'maxlength' => '255'
412+
),
402413
'apache_directives' => array (
403414
'datatype' => 'TEXT',
404415
'formtype' => 'TEXT',

interface/web/sites/lib/lang/en_web_domain.lng

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,4 +47,5 @@ $wb['error_ssl_organisation_unit_empty'] = 'SSL Organisation Unit is empty.';
4747
$wb['error_ssl_country_empty'] = 'SSL Country is empty.';
4848
$wb["client_group_id_txt"] = 'Client';
4949
$wb["stats_password_txt"] = 'Webstatistics password';
50+
$wb["allow_override_txt"] = 'Allow Override';
5051
?>

interface/web/sites/templates/web_domain_advanced.htm

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@ <h2><tmpl_var name="list_head_txt"></h2>
1616
<label for="system_group">{tmpl_var name='system_group'}</label>
1717
<input name="system_group" id="system_group" value="{tmpl_var name='system_group'}" type="hidden" />
1818
</div>
19+
<div class="ctrlHolder">
20+
<label for="allow_override">{tmpl_var name='allow_override_txt'}</label>
21+
<input name="allow_override" id="allow_override" value="{tmpl_var name='allow_override'}" size="30" maxlength="255" type="text" class="textInput" />
22+
</div
1923
<div class="ctrlHolder">
2024
<label for="apache_directives">{tmpl_var name='apache_directives_txt'}</label>
2125
<textarea name="apache_directives" id="apache_directives" rows='10' cols='30'>{tmpl_var name='apache_directives'}</textarea>

server/conf/vhost.conf.master

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
<Directory {tmpl_var name='web_document_root_www'}>
3838
Options FollowSymLinks
39-
AllowOverride All
39+
AllowOverride <tmpl_var name='allow_override'>
4040
Order allow,deny
4141
Allow from all
4242
<tmpl_if name='ssi' op='==' value='y'>
@@ -56,7 +56,7 @@
5656
</Directory>
5757
<Directory {tmpl_var name='web_document_root'}>
5858
Options FollowSymLinks
59-
AllowOverride All
59+
AllowOverride <tmpl_var name='allow_override'>
6060
Order allow,deny
6161
Allow from all
6262
<tmpl_if name='ssi' op='==' value='y'>
@@ -124,7 +124,7 @@
124124
AddHandler fcgid-script .php .php3 .php4 .php5
125125
FCGIWrapper <tmpl_var name='fastcgi_starter_path'><tmpl_var name='fastcgi_starter_script'> .php
126126
Options +ExecCGI
127-
AllowOverride all
127+
AllowOverride <tmpl_var name='allow_override'>
128128
Order allow,deny
129129
Allow from all
130130
</Directory>
@@ -192,7 +192,7 @@
192192

193193
<Directory {tmpl_var name='web_document_root_www'}>
194194
Options FollowSymLinks
195-
AllowOverride All
195+
AllowOverride <tmpl_var name='allow_override'>
196196
Order allow,deny
197197
Allow from all
198198
<tmpl_if name='ssi' op='==' value='y'>
@@ -212,7 +212,7 @@
212212
</Directory>
213213
<Directory {tmpl_var name='web_document_root'}>
214214
Options FollowSymLinks
215-
AllowOverride All
215+
AllowOverride <tmpl_var name='allow_override'>
216216
Order allow,deny
217217
Allow from all
218218
<tmpl_if name='ssi' op='==' value='y'>
@@ -282,7 +282,7 @@
282282
AddHandler fcgid-script .php .php3 .php4 .php5
283283
FCGIWrapper <tmpl_var name='fastcgi_starter_path'><tmpl_var name='fastcgi_starter_script'> .php
284284
Options +ExecCGI
285-
AllowOverride all
285+
AllowOverride <tmpl_var name='allow_override'>
286286
Order allow,deny
287287
Allow from all
288288
</Directory>

server/plugins-available/apache2_plugin.inc.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -554,6 +554,7 @@ function update($event_name,$data) {
554554
$vhost_data["web_document_root_www"] = $web_config["website_basedir"]."/".$data["new"]["domain"]."/web";
555555
$vhost_data["web_basedir"] = $web_config["website_basedir"];
556556
$vhost_data["security_level"] = $web_config["security_level"];
557+
$vhost_data["allow_override"] = ($data["new"]["allow_override"] == '')?'All':$data["new"]["allow_override"];
557558

558559
// Check if a SSL cert exists
559560
$ssl_dir = $data["new"]["document_root"]."/ssl";

0 commit comments

Comments
 (0)