Skip to content

Commit e92eda2

Browse files
author
Till Brehm
committed
Fixed: FS#3312 - Bug in APS remove
1 parent 5e10d2d commit e92eda2

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

install/lib/installer_base.lib.php

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -474,7 +474,15 @@ public function grant_master_database_rights($verbose = false) {
474474
$this->warning('Unable to set rights of user in master database: '.$value['db']."\n Query: ".$query."\n Error: ".$this->dbmaster->errorMessage);
475475
}
476476

477-
$query = "GRANT SELECT, UPDATE ON ".$value['db'].".`aps_instances` TO '".$value['user']."'@'".$host."' ";
477+
$query = "GRANT SELECT, UPDATE, DELETE ON ".$value['db'].".`aps_instances` TO '".$value['user']."'@'".$host."' ";
478+
if ($verbose){
479+
echo $query ."\n";
480+
}
481+
if(!$this->dbmaster->query($query)) {
482+
$this->warning('Unable to set rights of user in master database: '.$value['db']."\n Query: ".$query."\n Error: ".$this->dbmaster->errorMessage);
483+
}
484+
485+
$query = "GRANT SELECT, DELETE ON ".$value['db'].".`aps_instances_settings` TO '".$value['user']."'@'".$host."' ";
478486
if ($verbose){
479487
echo $query ."\n";
480488
}

server/lib/classes/aps_installer.inc.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -739,6 +739,10 @@ public function installHandler($instanceid, $type)
739739
{
740740
$app->db->query('DELETE FROM aps_instances WHERE id = "'.$app->db->quote($task['instance_id']).'";');
741741
$app->db->query('DELETE FROM aps_instances_settings WHERE instance_id = "'.$app->db->quote($task['instance_id']).'";');
742+
if ($app->dbmaster != $app->db) {
743+
$app->dbmaster->query('DELETE FROM aps_instances WHERE id = "'.$app->db->quote($task['instance_id']).'";');
744+
$app->dbmaster->query('DELETE FROM aps_instances_settings WHERE instance_id = "'.$app->db->quote($task['instance_id']).'";');
745+
}
742746
}
743747

744748
unset($sxe);

0 commit comments

Comments
 (0)