Skip to content

Commit daae107

Browse files
author
Marius Burkard
committed
Merge branch 'server_alias' into 'master'
Server alias before: ``` ServerAlias domain ServerAlias alias0 ServerAlias alias1 ``` after (8 alias per line example): ``` ServerAlias www.kljsf.com kljsf.com www.kjdf.org kjdf.org www.klsdjf.put klsdjf.put www.skdf.jak skdf.jak ServerAlias www.abc.com abc.com www.bca.com bca.com www.ksd.com ksd.com www.lkjas.com lkjas.com ServerAlias www.kak.com kak.com www.skdf.jaku skdf.jaku www.klsjdf.jks klsjdf.jks www.lksdjf.kj lksdjf.kj ServerAlias www.lkdj.kjdf lkdj.kjdf www.klsdjf.jksdf klsdjf.jksdf www.hjd.hja hjd.hja www.lksjdf.ujk lksjdf.ujk ServerAlias www.lksjdfl.lskdjf lksjdfl.lskdjf www.kjsdlkfj.sdfj kjsdlkfj.sdfj www.lksdjf.sdkf lksdjf.sdkf www.kjflksjf.ksdfl kjflksjf.ksdfl ServerAlias www.lskdjf.ksdf lskdjf.ksdf www.lksjdf.lksjdf lksjdf.lksjdf www.kjhf.ksjdf kjhf.ksjdf ``` See merge request !543
2 parents 5099d3f + 7e2f8b6 commit daae107

File tree

1 file changed

+15
-19
lines changed

1 file changed

+15
-19
lines changed

server/plugins-available/apache2_plugin.inc.php

Lines changed: 15 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1422,31 +1422,31 @@ function update($event_name, $data) {
14221422
unset($client);
14231423
unset($aa_search);
14241424
unset($aa_replace);
1425-
$server_alias[] .= $auto_alias.' ';
1425+
$server_alias[] .= $auto_alias;
14261426
}
14271427

14281428
// get alias domains (co-domains and subdomains)
14291429
$aliases = $app->db->queryAllRecords("SELECT * FROM web_domain WHERE parent_domain_id = ? AND active = 'y' AND (type != 'vhostsubdomain' AND type != 'vhostalias')", $data['new']['domain_id']);
14301430
$alias_seo_redirects = array();
14311431
switch($data['new']['subdomain']) {
14321432
case 'www':
1433-
$server_alias[] = 'www.'.$data['new']['domain'].' ';
1433+
$server_alias[] = 'www.'.$data['new']['domain'];
14341434
break;
14351435
case '*':
1436-
$server_alias[] = '*.'.$data['new']['domain'].' ';
1436+
$server_alias[] = '*.'.$data['new']['domain'];
14371437
break;
14381438
}
14391439
if(is_array($aliases)) {
14401440
foreach($aliases as $alias) {
14411441
switch($alias['subdomain']) {
14421442
case 'www':
1443-
$server_alias[] .= 'www.'.$alias['domain'].' '.$alias['domain'].' ';
1443+
$server_alias[] .= 'www.'.$alias['domain'].' '.$alias['domain'];
14441444
break;
14451445
case '*':
1446-
$server_alias[] .= '*.'.$alias['domain'].' '.$alias['domain'].' ';
1446+
$server_alias[] .= '*.'.$alias['domain'].' '.$alias['domain'];
14471447
break;
14481448
default:
1449-
$server_alias[] .= $alias['domain'].' ';
1449+
$server_alias[] .= $alias['domain'];
14501450
break;
14511451
}
14521452
$app->log('Add server alias: '.$alias['domain'], LOGLEVEL_DEBUG);
@@ -1513,22 +1513,18 @@ function update($event_name, $data) {
15131513
}
15141514

15151515
//* If we have some alias records
1516-
if(count($server_alias) > 0) {
1517-
$server_alias_str = '';
1518-
$n = 0;
1519-
1520-
// begin a new ServerAlias line after 30 alias domains
1521-
foreach($server_alias as $tmp_alias) {
1522-
if($n % 30 == 0) $server_alias_str .= "\n ServerAlias ";
1523-
$server_alias_str .= $tmp_alias;
1524-
}
1525-
unset($tmp_alias);
1526-
1527-
$tpl->setVar('alias', trim($server_alias_str));
1516+
if($server_alias) {
1517+
//* begin a new ServerAlias line after 32 alias domains to avoid apache bugs
1518+
$server_alias_str = 'ServerAlias '.$server_alias[0];
1519+
for($n=1;$n<count($server_alias);++$n)
1520+
$server_alias_str .= ($n % 32?' ':"\nServerAlias ").$server_alias[$n];
1521+
$tpl->setVar('alias', $server_alias_str);
1522+
unset($server_alias_str);
1523+
unset($n);
15281524
} else {
15291525
$tpl->setVar('alias', '');
15301526
}
1531-
1527+
15321528
if (count($rewrite_wildcard_rules) > 0) $rewrite_rules = array_merge($rewrite_rules, $rewrite_wildcard_rules); // Append wildcard rules to the end of rules
15331529

15341530
if(count($rewrite_rules) > 0 || $vhost_data['seo_redirect_enabled'] > 0 || count($alias_seo_redirects) > 0 || $data['new']['rewrite_to_https'] == 'y') {

0 commit comments

Comments
 (0)