Merge branch '5728-stable-old-caa-requiered-le-cert-s-can-t-issued-anymore' into 'develop'

Marius Burkard · Marius Burkard · commit d7151cce9bd0 · 2020-09-09T12:36:29.000+02:00
Resolve "[Stable-old] CAA requiered? LE Cert's can't issued anymore"

Closes #5728

See merge request ispconfig/ispconfig3!1134
diff --git a/server/lib/classes/letsencrypt.inc.php b/server/lib/classes/letsencrypt.inc.php
@@ -386,7 +386,7 @@ public function request_certificates($data, $server_type = 'apache') {
 				}
 				$caa_records = @dns_get_record($caa_domain, DNS_CAA); // requieres PHP 7.0.16, 7.1.2
 				if(is_array($caa_records) && !empty($caa_records)) {
-					foreach ($records as $record) {
+					foreach ($caa_records as $record) {
 						if($record['value'] == 'letsencrypt.org') $caa_check = true;
 					}
 				} else {

Original file line number	Diff line number	Diff line change
`@@ -386,7 +386,7 @@ public function request_certificates($data, $server_type = 'apache') {`
`386`	`386`	`}`
`387`	`387`	`$caa_records = @dns_get_record($caa_domain, DNS_CAA); // requieres PHP 7.0.16, 7.1.2`
`388`	`388`	`if(is_array($caa_records) && !empty($caa_records)) {`
`389`		`- foreach ($records as $record) {`
	`389`	`+ foreach ($caa_records as $record) {`
`390`	`390`	`if($record['value'] == 'letsencrypt.org') $caa_check = true;`
`391`	`391`	`}`
`392`	`392`	`} else {`