changes from review feedback

jnorell · jnorell · commit d12a7064ea34 · 2020-09-01T10:18:29.000-06:00
diff --git a/interface/lib/plugins/mail_user_filter_plugin.inc.php b/interface/lib/plugins/mail_user_filter_plugin.inc.php
@@ -139,8 +139,7 @@ private function mail_user_filter_get_rule($page_form) {
 
 			if($page_form->dataRecord["source"] == 'Header') {
 				$parts = explode(':',trim($page_form->dataRecord["searchterm"]));
-				$page_form->dataRecord["source"] = trim($parts[0]);
-				unset($parts[0]);
+				$page_form->dataRecord["source"] = trim(array_shift($parts));
 				$page_form->dataRecord["searchterm"] = trim(implode(':',$parts));
 				unset($parts);
 			}
diff --git a/security/ids.whitelist b/security/ids.whitelist
@@ -55,7 +55,6 @@ user:/login/index.php:POST.password
 user:/mail/mail_domain_edit.php:POST.dkim_private
 user:/mail/mail_domain_edit.php:POST.dkim_public
 user:/mail/mail_domain_edit.php:POST.dns_record
-user:/sites/web_vhost_domain_edit.php:POST.fastcgi_php_version
 admin:/mail/mail_user_filter_edit.php:POST.searchterm
 user:/mail/mail_user_filter_edit.php:POST.searchterm
 admin:/mail/mail_user_edit.php:POST.custom_mailfilter

Original file line number	Diff line number	Diff line change
`@@ -139,8 +139,7 @@ private function mail_user_filter_get_rule($page_form) {`
`139`	`139`
`140`	`140`	`if($page_form->dataRecord["source"] == 'Header') {`
`141`	`141`	`$parts = explode(':',trim($page_form->dataRecord["searchterm"]));`
`142`		`- $page_form->dataRecord["source"] = trim($parts[0]);`
`143`		`- unset($parts[0]);`
	`142`	`+ $page_form->dataRecord["source"] = trim(array_shift($parts));`
`144`	`143`	`$page_form->dataRecord["searchterm"] = trim(implode(':',$parts));`
`145`	`144`	`unset($parts);`
`146`	`145`	`}`