Skip to content

Commit d1086fc

Browse files
author
vogelor
committed
Fixed a bug in creating ssl on multiserver-environments (NO security bug, only a "handling" bug!)
1 parent 7c3b600 commit d1086fc

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

server/plugins-available/apache2_plugin.inc.php

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,8 +146,12 @@ function ssl($event_name,$data) {
146146
@unlink($rand_file);
147147
$ssl_request = file_get_contents($csr_file);
148148
$ssl_cert = file_get_contents($crt_file);
149+
/* Update the DB of the (local) Server */
149150
$app->db->query("UPDATE web_domain SET ssl_request = '$ssl_request', ssl_cert = '$ssl_cert' WHERE domain = '".$data["new"]["domain"]."'");
150151
$app->db->query("UPDATE web_domain SET ssl_action = '' WHERE domain = '".$data["new"]["domain"]."'");
152+
/* Update also the master-DB of the Server-Farm */
153+
$app->dbmaster->query("UPDATE web_domain SET ssl_request = '$ssl_request', ssl_cert = '$ssl_cert' WHERE domain = '".$data["new"]["domain"]."'");
154+
$app->dbmaster->query("UPDATE web_domain SET ssl_action = '' WHERE domain = '".$data["new"]["domain"]."'");
151155
}
152156

153157
//* Save a SSL certificate to disk
@@ -160,7 +164,10 @@ function ssl($event_name,$data) {
160164
file_put_contents($csr_file,$data["new"]["ssl_request"]);
161165
file_put_contents($crt_file,$data["new"]["ssl_cert"]);
162166
if(trim($data["new"]["ssl_bundle"]) != '') file_put_contents($bundle_file,$data["new"]["ssl_bundle"]);
167+
/* Update the DB of the (local) Server */
163168
$app->db->query("UPDATE web_domain SET ssl_action = '' WHERE domain = '".$data["new"]["domain"]."'");
169+
/* Update also the master-DB of the Server-Farm */
170+
$app->dbmaster->query("UPDATE web_domain SET ssl_action = '' WHERE domain = '".$data["new"]["domain"]."'");
164171
$app->log("Saving SSL Cert for: $domain",LOGLEVEL_DEBUG);
165172
}
166173

@@ -174,7 +181,12 @@ function ssl($event_name,$data) {
174181
unlink($csr_file);
175182
unlink($crt_file);
176183
unlink($bundle_file);
184+
/* Update the DB of the (local) Server */
185+
$app->db->query("UPDATE web_domain SET ssl_request = '', ssl_cert = '' WHERE domain = '".$data["new"]["domain"]."'");
177186
$app->db->query("UPDATE web_domain SET ssl_action = '' WHERE domain = '".$data["new"]["domain"]."'");
187+
/* Update also the master-DB of the Server-Farm */
188+
$app->dbmaster->query("UPDATE web_domain SET ssl_request = '', ssl_cert = '' WHERE domain = '".$data["new"]["domain"]."'");
189+
$app->dbmaster->query("UPDATE web_domain SET ssl_action = '' WHERE domain = '".$data["new"]["domain"]."'");
178190
$app->log("Deleting SSL Cert for: $domain",LOGLEVEL_DEBUG);
179191
}
180192

0 commit comments

Comments
 (0)