Fixed: #3928 usage of deprecated php function split.

Till Brehm · Till Brehm · commit bd6f59523ed1 · 2016-05-26T18:14:48.000+02:00
diff --git a/server/plugins-available/apache2_plugin.inc.php b/server/plugins-available/apache2_plugin.inc.php
@@ -1234,7 +1234,7 @@ function update($event_name, $data) {
 				$app->log("Create Let's Encrypt SSL Cert for: $domain", LOGLEVEL_DEBUG);
 				
 				$success = false;
-				$letsencrypt = array_shift( split("\n", `which letsencrypt /root/.local/share/letsencrypt/bin/letsencrypt`) );
+				$letsencrypt = array_shift( explode("\n", `which letsencrypt /root/.local/share/letsencrypt/bin/letsencrypt`) );
 				if(is_executable($letsencrypt)) {
 					$success = $this->_exec($letsencrypt . " auth --text --agree-tos --authenticator webroot --server https://acme-v01.api.letsencrypt.org/directory --rsa-key-size 4096 --email postmaster@$domain --domains $lddomain --webroot-path /usr/local/ispconfig/interface/acme");
 				}
diff --git a/server/plugins-available/nginx_plugin.inc.php b/server/plugins-available/nginx_plugin.inc.php
@@ -1312,7 +1312,7 @@ function update($event_name, $data) {
 				$app->log("Create Let's Encrypt SSL Cert for: $domain", LOGLEVEL_DEBUG);
 				
 				$success = false;
-				$letsencrypt = array_shift( split("\n", `which letsencrypt /root/.local/share/letsencrypt/bin/letsencrypt`) );
+				$letsencrypt = array_shift( explode("\n", `which letsencrypt /root/.local/share/letsencrypt/bin/letsencrypt`) );
 				if(is_executable($letsencrypt)) {
 					$success = $this->_exec($letsencrypt . " auth --text --agree-tos --authenticator webroot --server https://acme-v01.api.letsencrypt.org/directory --rsa-key-size 4096 --email postmaster@$domain --domains $lddomain --webroot-path /usr/local/ispconfig/interface/acme");
 				}

Original file line number	Diff line number	Diff line change
`@@ -1234,7 +1234,7 @@ function update($event_name, $data) {`
`1234`	`1234`	`$app->log("Create Let's Encrypt SSL Cert for: $domain", LOGLEVEL_DEBUG);`
`1235`	`1235`
`1236`	`1236`	`$success = false;`
`1237`		- $letsencrypt = array_shift( split("\n", `which letsencrypt /root/.local/share/letsencrypt/bin/letsencrypt`) );
	`1237`	+ $letsencrypt = array_shift( explode("\n", `which letsencrypt /root/.local/share/letsencrypt/bin/letsencrypt`) );
`1238`	`1238`	`if(is_executable($letsencrypt)) {`
`1239`	`1239`	`$success = $this->_exec($letsencrypt . " auth --text --agree-tos --authenticator webroot --server https://acme-v01.api.letsencrypt.org/directory --rsa-key-size 4096 --email postmaster@$domain --domains $lddomain --webroot-path /usr/local/ispconfig/interface/acme");`
`1240`	`1240`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1312,7 +1312,7 @@ function update($event_name, $data) {`
`1312`	`1312`	`$app->log("Create Let's Encrypt SSL Cert for: $domain", LOGLEVEL_DEBUG);`
`1313`	`1313`
`1314`	`1314`	`$success = false;`
`1315`		- $letsencrypt = array_shift( split("\n", `which letsencrypt /root/.local/share/letsencrypt/bin/letsencrypt`) );
	`1315`	+ $letsencrypt = array_shift( explode("\n", `which letsencrypt /root/.local/share/letsencrypt/bin/letsencrypt`) );
`1316`	`1316`	`if(is_executable($letsencrypt)) {`
`1317`	`1317`	`$success = $this->_exec($letsencrypt . " auth --text --agree-tos --authenticator webroot --server https://acme-v01.api.letsencrypt.org/directory --rsa-key-size 4096 --email postmaster@$domain --domains $lddomain --webroot-path /usr/local/ispconfig/interface/acme");`
`1318`	`1318`	`}`