Remove comments before passing to postconf, fixes #5756

helmo · helmo · commit b7f836a3fb72 · 2020-09-22T10:15:47.000+02:00
diff --git a/install/lib/installer_base.lib.php b/install/lib/installer_base.lib.php
@@ -1169,6 +1169,9 @@ public function configure_postfix($options = '') {
 		    $postconf_commands = array_merge($postconf_commands, array_filter(explode("\n", $content)));
 		}
 
+		// Remove comment lines, these would give fatal errors when passed to postconf.
+		$postconf_commands = array_filter($postconf_commands, function($line) { return preg_match('/^[^#]/', $line); });
+
 		//* These postconf commands will be executed on installation only
 		if($this->is_update == false) {
 			$postconf_commands = array_merge($postconf_commands, array(

Original file line number	Diff line number	Diff line change
`@@ -1169,6 +1169,9 @@ public function configure_postfix($options = '') {`
`1169`	`1169`	`$postconf_commands = array_merge($postconf_commands, array_filter(explode("\n", $content)));`
`1170`	`1170`	`}`
`1171`	`1171`
	`1172`	`+ // Remove comment lines, these would give fatal errors when passed to postconf.`
	`1173`	`+ $postconf_commands = array_filter($postconf_commands, function($line) { return preg_match('/^[^#]/', $line); });`
	`1174`	`+`
`1172`	`1175`	`//* These postconf commands will be executed on installation only`
`1173`	`1176`	`if($this->is_update == false) {`
`1174`	`1177`	`$postconf_commands = array_merge($postconf_commands, array(`