Update the serial after the actual insert, #6690

helmo · helmo · commit a86b05a02215 · 2024-04-15T23:46:43.000+02:00
diff --git a/interface/lib/classes/remote.d/dns.inc.php b/interface/lib/classes/remote.d/dns.inc.php
@@ -218,10 +218,11 @@ private function dns_rr_add($session_id, $client_id, $params, $update_serial=fal
 		if(!$this->checkPerm($session_id, 'dns_' . $rr_type . '_add')) {
 			throw new SoapFault('permission_denied', 'You do not have the permissions to access this function.');
 		}
+		$primary_id = $this->insertQuery('../dns/form/dns_' . $rr_type . '.tform.php', $client_id, $params);
 		if($update_serial) {
 			$this->increase_serial($session_id, $client_id, $params);
 		}
-		return $this->insertQuery('../dns/form/dns_' . $rr_type . '.tform.php', $client_id, $params);
+		return $primary_id;
 	}
 
 	//* Update a record

Original file line number	Diff line number	Diff line change
`@@ -218,10 +218,11 @@ private function dns_rr_add($session_id, $client_id, $params, $update_serial=fal`
`218`	`218`	`if(!$this->checkPerm($session_id, 'dns_' . $rr_type . '_add')) {`
`219`	`219`	`throw new SoapFault('permission_denied', 'You do not have the permissions to access this function.');`
`220`	`220`	`}`
	`221`	`+ $primary_id = $this->insertQuery('../dns/form/dns_' . $rr_type . '.tform.php', $client_id, $params);`
`221`	`222`	`if($update_serial) {`
`222`	`223`	`$this->increase_serial($session_id, $client_id, $params);`
`223`	`224`	`}`
`224`		`- return $this->insertQuery('../dns/form/dns_' . $rr_type . '.tform.php', $client_id, $params);`
	`225`	`+ return $primary_id;`
`225`	`226`	`}`
`226`	`227`
`227`	`228`	`//* Update a record`