- too many arguments for useradd in shell user plugin

Marius Burkard · Marius Burkard · commit a68bd9a76c61 · 2019-07-31T16:09:03.000+02:00
diff --git a/server/plugins-available/shelluser_base_plugin.inc.php b/server/plugins-available/shelluser_base_plugin.inc.php
@@ -128,7 +128,7 @@ function insert($event_name, $data) {
 					$app->system->chown($homedir,$data['new']['puser'],false);
 					$app->system->chgrp($homedir,$data['new']['pgroup'],false);
 				}
-				$command = 'useradd -d ? -g ? -o ?'; // non unique
+				$command = 'useradd -d ? -g ? -o'; // non unique
 				if($data['new']['password'] != '') $command .= ' -p ' . escapeshellarg($data['new']['password']);
 				$command .= ' -s ? -u ? ?';
 				$app->system->exec_safe($command, $homedir, $data['new']['pgroup'], $data['new']['shell'], $uid, $data['new']['username']);

Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,7 @@ function insert($event_name, $data) {`
`128`	`128`	`$app->system->chown($homedir,$data['new']['puser'],false);`
`129`	`129`	`$app->system->chgrp($homedir,$data['new']['pgroup'],false);`
`130`	`130`	`}`
`131`		`- $command = 'useradd -d ? -g ? -o ?'; // non unique`
	`131`	`+ $command = 'useradd -d ? -g ? -o'; // non unique`
`132`	`132`	`if($data['new']['password'] != '') $command .= ' -p ' . escapeshellarg($data['new']['password']);`
`133`	`133`	`$command .= ' -s ? -u ? ?';`
`134`	`134`	`$app->system->exec_safe($command, $homedir, $data['new']['pgroup'], $data['new']['shell'], $uid, $data['new']['username']);`