Skip to content

Commit 9bce571

Browse files
committed
fix database name escaping
1 parent ca5966f commit 9bce571

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

server/plugins-available/mysql_clientdb_plugin.inc.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ function process_host_list($action, $database_name, $database_user, $database_pa
137137
if($user_access_mode == 'r') $grants = 'SELECT';
138138
elseif($user_access_mode == 'rd') $grants = 'SELECT, DELETE, ALTER, DROP';
139139

140-
$database_name = str_replace('_', '\\_', $link->escape_string($database_name));
140+
$database_name = str_replace('_', '\_', $link->escape_string($database_name));
141141

142142
if($action == 'GRANT') {
143143
if($user_access_mode == 'r' || $user_access_mode == 'rd') {
@@ -168,8 +168,8 @@ function process_host_list($action, $database_name, $database_user, $database_pa
168168
}
169169

170170
// Set the grant
171-
if(!$link->query("GRANT " . $grants . " ON `".$link->escape_string($database_name)."`.* TO '".$link->escape_string($database_user)."'@'$db_host'")) $success = false;
172-
$app->log("GRANT " . $grants . " ON `".$link->escape_string($database_name)."`.* TO '".$link->escape_string($database_user)."'@'$db_host' success? " . ($success ? 'yes' : 'no'), LOGLEVEL_DEBUG);
171+
if(!$link->query("GRANT " . $grants . " ON `".$database_name."`.* TO '".$link->escape_string($database_user)."'@'$db_host'")) $success = false;
172+
$app->log("GRANT " . $grants . " ON `".$database_name."`.* TO '".$link->escape_string($database_user)."'@'$db_host' success? " . ($success ? 'yes' : 'no'), LOGLEVEL_DEBUG);
173173

174174
} elseif($action == 'REVOKE') {
175175
if(!$link->query("REVOKE ALL PRIVILEGES ON `".$database_name."`.* FROM '".$link->escape_string($database_user)."'@'$db_host'")) $success = false;

0 commit comments

Comments
 (0)