Skip to content

Commit 9af8746

Browse files
committed
LE: add "Revoke before delete" and "Delete on Site delete" options #5226 #6563
1 parent 8fd4e62 commit 9af8746

33 files changed

+226
-58
lines changed

install/tpl/server.ini.master

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,9 @@ vhost_proxy_protocol_protocols=ipv4
143143
vhost_proxy_protocol_http_port=880
144144
vhost_proxy_protocol_https_port=8443
145145
le_signature_type=ECDSA
146+
le_delete_on_site_remove=y
146147
le_auto_cleanup=y
148+
le_revoke_before_delete=y
147149
le_auto_cleanup_denylist=[server_name]
148150

149151
[dns]

interface/web/admin/form/server_config.tform.php

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1639,6 +1639,12 @@
16391639
'default' => 'ECDSA',
16401640
'value' => array('RSA' => 'RSA (RSA encryption with SHA-256)', 'ECDSA' => 'ECDSA (Elliptic Curve Digital Signature Algorithm)')
16411641
),
1642+
'le_delete_on_site_remove' => array(
1643+
'datatype' => 'VARCHAR',
1644+
'formtype' => 'CHECKBOX',
1645+
'default' => 'y',
1646+
'value' => array(0 => 'n', 1 => 'y')
1647+
),
16421648
'le_auto_cleanup' => array(
16431649
'datatype' => 'VARCHAR',
16441650
'formtype' => 'CHECKBOX',
@@ -1664,6 +1670,12 @@
16641670
'width' => '40',
16651671
'maxlength' => '255'
16661672
),
1673+
'le_revoke_before_delete' => array(
1674+
'datatype' => 'VARCHAR',
1675+
'formtype' => 'CHECKBOX',
1676+
'default' => 'y',
1677+
'value' => array(0 => 'n', 1 => 'y')
1678+
),
16671679
//#################################
16681680
// END Datatable fields
16691681
//#################################

interface/web/admin/lib/lang/ar_server_config.lng

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -368,3 +368,5 @@ $wb['le_auto_cleanup_txt'] = 'Automatically purge unused Let\'s Encrypt certific
368368
$wb['le_auto_cleanup_denylist_txt'] = 'Domains that should never be purged';
369369
$wb['le_auto_cleanup_denylist_note_txt'] = 'Comma separated list of domain globs that should not be purged. <br>E.g. <code>mail.*, externally-managed.example.com</code> <br>Placeholders:';
370370
$wb['le_auto_cleanup_denylist_error_custom'] = 'Invalid list of domain globs';
371+
$wb['le_delete_on_site_remove_txt'] = 'Delete Let\'s Encrypt certificate on website removal';
372+
$wb['le_revoke_before_delete_txt'] = 'Revoke a certificate before deleting it (prevents Let\'s Encrypt renewal warnings)';

interface/web/admin/lib/lang/bg_server_config.lng

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -368,3 +368,5 @@ $wb['le_auto_cleanup_txt'] = 'Automatically purge unused Let\'s Encrypt certific
368368
$wb['le_auto_cleanup_denylist_txt'] = 'Domains that should never be purged';
369369
$wb['le_auto_cleanup_denylist_note_txt'] = 'Comma separated list of domain globs that should not be purged. <br>E.g. <code>mail.*, externally-managed.example.com</code> <br>Placeholders:';
370370
$wb['le_auto_cleanup_denylist_error_custom'] = 'Invalid list of domain globs';
371+
$wb['le_delete_on_site_remove_txt'] = 'Delete Let\'s Encrypt certificate on website removal';
372+
$wb['le_revoke_before_delete_txt'] = 'Revoke a certificate before deleting it (prevents Let\'s Encrypt renewal warnings)';

interface/web/admin/lib/lang/br_server_config.lng

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -369,3 +369,5 @@ $wb['le_auto_cleanup_txt'] = 'Automatically purge unused Let\'s Encrypt certific
369369
$wb['le_auto_cleanup_denylist_txt'] = 'Domains that should never be purged';
370370
$wb['le_auto_cleanup_denylist_note_txt'] = 'Comma separated list of domain globs that should not be purged. <br>E.g. <code>mail.*, externally-managed.example.com</code> <br>Placeholders:';
371371
$wb['le_auto_cleanup_denylist_error_custom'] = 'Invalid list of domain globs';
372+
$wb['le_delete_on_site_remove_txt'] = 'Delete Let\'s Encrypt certificate on website removal';
373+
$wb['le_revoke_before_delete_txt'] = 'Revoke a certificate before deleting it (prevents Let\'s Encrypt renewal warnings)';

interface/web/admin/lib/lang/ca_server_config.lng

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -368,3 +368,5 @@ $wb['le_auto_cleanup_txt'] = 'Automatically purge unused Let\'s Encrypt certific
368368
$wb['le_auto_cleanup_denylist_txt'] = 'Domains that should never be purged';
369369
$wb['le_auto_cleanup_denylist_note_txt'] = 'Comma separated list of domain globs that should not be purged. <br>E.g. <code>mail.*, externally-managed.example.com</code> <br>Placeholders:';
370370
$wb['le_auto_cleanup_denylist_error_custom'] = 'Invalid list of domain globs';
371+
$wb['le_delete_on_site_remove_txt'] = 'Delete Let\'s Encrypt certificate on website removal';
372+
$wb['le_revoke_before_delete_txt'] = 'Revoke a certificate before deleting it (prevents Let\'s Encrypt renewal warnings)';

interface/web/admin/lib/lang/cn_server_config.lng

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -368,3 +368,5 @@ $wb['le_auto_cleanup_txt'] = 'Automatically purge unused Let\'s Encrypt certific
368368
$wb['le_auto_cleanup_denylist_txt'] = 'Domains that should never be purged';
369369
$wb['le_auto_cleanup_denylist_note_txt'] = 'Comma separated list of domain globs that should not be purged. <br>E.g. <code>mail.*, externally-managed.example.com</code> <br>Placeholders:';
370370
$wb['le_auto_cleanup_denylist_error_custom'] = 'Invalid list of domain globs';
371+
$wb['le_delete_on_site_remove_txt'] = 'Delete Let\'s Encrypt certificate on website removal';
372+
$wb['le_revoke_before_delete_txt'] = 'Revoke a certificate before deleting it (prevents Let\'s Encrypt renewal warnings)';

interface/web/admin/lib/lang/cz_server_config.lng

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -368,3 +368,5 @@ $wb['le_auto_cleanup_txt'] = 'Automatically purge unused Let\'s Encrypt certific
368368
$wb['le_auto_cleanup_denylist_txt'] = 'Domains that should never be purged';
369369
$wb['le_auto_cleanup_denylist_note_txt'] = 'Comma separated list of domain globs that should not be purged. <br>E.g. <code>mail.*, externally-managed.example.com</code> <br>Placeholders:';
370370
$wb['le_auto_cleanup_denylist_error_custom'] = 'Invalid list of domain globs';
371+
$wb['le_delete_on_site_remove_txt'] = 'Delete Let\'s Encrypt certificate on website removal';
372+
$wb['le_revoke_before_delete_txt'] = 'Revoke a certificate before deleting it (prevents Let\'s Encrypt renewal warnings)';

interface/web/admin/lib/lang/de_server_config.lng

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -368,3 +368,5 @@ $wb['le_auto_cleanup_txt'] = 'Entferne unbenutzte Let\'s Encrypt Zertifikate aut
368368
$wb['le_auto_cleanup_denylist_txt'] = 'Domains die nie entfernt werden sollen';
369369
$wb['le_auto_cleanup_denylist_note_txt'] = 'Komma-separierte Liste von Domain-Globs, die niemals entfernt werden sollen. <br>Z.B. <code>mail.*, externally-managed.example.com</code> <br>Platzhalter:';
370370
$wb['le_auto_cleanup_denylist_error_custom'] = 'Domain-Glob Liste ungültig';
371+
$wb['le_delete_on_site_remove_txt'] = 'Delete Let\'s Encrypt certificate on website removal';
372+
$wb['le_revoke_before_delete_txt'] = 'Revoke a certificate before deleting it (prevents Let\'s Encrypt renewal warnings)';

interface/web/admin/lib/lang/dk_server_config.lng

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -368,3 +368,5 @@ $wb['le_auto_cleanup_txt'] = 'Automatically purge unused Let\'s Encrypt certific
368368
$wb['le_auto_cleanup_denylist_txt'] = 'Domains that should never be purged';
369369
$wb['le_auto_cleanup_denylist_note_txt'] = 'Comma separated list of domain globs that should not be purged. <br>E.g. <code>mail.*, externally-managed.example.com</code> <br>Placeholders:';
370370
$wb['le_auto_cleanup_denylist_error_custom'] = 'Invalid list of domain globs';
371+
$wb['le_delete_on_site_remove_txt'] = 'Delete Let\'s Encrypt certificate on website removal';
372+
$wb['le_revoke_before_delete_txt'] = 'Revoke a certificate before deleting it (prevents Let\'s Encrypt renewal warnings)';

0 commit comments

Comments
 (0)