Skip to content

Commit 9ab5689

Browse files
author
Marius Burkard
committed
- addon installer fixes
1 parent 2bdcab1 commit 9ab5689

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

server/lib/classes/addon_installer.inc.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -176,6 +176,8 @@ public function installAddon($package_file, $force = false) {
176176
$inst->onAfterInstall();
177177
}
178178

179+
exec('rm -rf ' . escapeshellarg($tmp_dir));
180+
179181
return true;
180182
}
181183

server/lib/classes/ispconfig_addon_installer_base.inc.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,10 +85,10 @@ protected function copyAddonFiles() {
8585
if(is_dir($this->temp_dir . '/install')) {
8686
$ret = null;
8787
$retval = 0;
88-
$command = 'cp -rf ' . escapeshellarg($this->temp_dir . '/addon.ini') . ' ' . escapeshellarg($this->temp_dir . '/' . $this->addon_ident . 'addon.php') . ' ' . escapeshellarg($this->temp_dir . '/install'). ' ' . escapeshellarg($install_dir . '/');
88+
$command = 'cp -rf ' . escapeshellarg($this->temp_dir . '/addon.ini') . ' ' . escapeshellarg($this->temp_dir . '/' . $this->addon_ident . '.addon.php') . ' ' . escapeshellarg($this->temp_dir . '/install'). ' ' . escapeshellarg($install_dir . '/');
8989
exec($command, $ret, $retval);
9090
if($retval != 0) {
91-
throw new AddonInstallerException('Command ' . $command . ' failed with code ' . $retval);
91+
/* TODO: logging */
9292
}
9393

9494
return true;
@@ -174,7 +174,7 @@ public function onAfterUpdate() { }
174174

175175

176176

177-
public function onRaisedInstallerEvent($event_name) {
177+
public function onRaisedInstallerEvent($event_name, $data) {
178178

179179
}
180180
}

0 commit comments

Comments
 (0)