better security for auth.log file

maddinxx · maddinxx · commit 99c89bf88077 · 2012-08-16T21:03:34.000Z
diff --git a/install/lib/installer_base.lib.php b/install/lib/installer_base.lib.php
@@ -1957,9 +1957,11 @@ public function install_ispconfig() {
 			touch($conf['ispconfig_log_dir'].'/ispconfig.log');
 		}
 
-		//* Create the ispconfig auth log file
+		//* Create the ispconfig auth log file and set uid/gid
 		if(!is_file($conf['ispconfig_log_dir'].'/auth.log')) {
-			touch($conf['ispconfig_log_dir'].'/auth.log', 0666);
+			touch($conf['ispconfig_log_dir'].'/auth.log');
+			exec('chown ispconfig:ispconfig '. $conf['ispconfig_log_dir'].'/auth.log');
+			exec('chmod 660 '. $conf['ispconfig_log_dir'].'/auth.log');
 		}
 
 		if(is_user('getmail')) {

Original file line number	Diff line number	Diff line change
`@@ -1957,9 +1957,11 @@ public function install_ispconfig() {`
`1957`	`1957`	`touch($conf['ispconfig_log_dir'].'/ispconfig.log');`
`1958`	`1958`	`}`
`1959`	`1959`
`1960`		`- //* Create the ispconfig auth log file`
	`1960`	`+ //* Create the ispconfig auth log file and set uid/gid`
`1961`	`1961`	`if(!is_file($conf['ispconfig_log_dir'].'/auth.log')) {`
`1962`		`- touch($conf['ispconfig_log_dir'].'/auth.log', 0666);`
	`1962`	`+ touch($conf['ispconfig_log_dir'].'/auth.log');`
	`1963`	`+ exec('chown ispconfig:ispconfig '. $conf['ispconfig_log_dir'].'/auth.log');`
	`1964`	`+ exec('chmod 660 '. $conf['ispconfig_log_dir'].'/auth.log');`
`1963`	`1965`	`}`
`1964`	`1966`
`1965`	`1967`	`if(is_user('getmail')) {`