Skip to content

Commit 9954d8f

Browse files
author
Marius Burkard
committed
Merge branch 'feature/admin_ip_whitelist' into 'develop'
Added admin IP whitelist feature See merge request ispconfig/ispconfig3!1544
2 parents b99d5de + 20a6092 commit 9954d8f

File tree

4 files changed

+429
-285
lines changed

4 files changed

+429
-285
lines changed

interface/lib/config.inc.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,4 +159,7 @@
159159
define('LOGLEVEL_WARN', 1);
160160
define('LOGLEVEL_ERROR', 2);
161161

162+
//** Admin IP whitelist file
163+
$conf['admin_ip_whitelist_file'] = '/usr/local/ispconfig/security/admin_ip.whitelist';
164+
162165
?>

interface/web/capp.php

Lines changed: 10 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -31,45 +31,37 @@
3131
require_once '../lib/config.inc.php';
3232
require_once '../lib/app.inc.php';
3333

34+
include_once 'common.php';
35+
3436
//* Import module variable
3537
$mod = $_REQUEST["mod"];
3638
//* If we click on a search result, load that one instead of the module's start page
3739
$redirect = (isset($_REQUEST["redirect"]) ? $_REQUEST["redirect"] : '');
3840

3941
//* Check if user is logged in
40-
if($_SESSION["s"]["user"]['active'] != 1) {
42+
if ($_SESSION["s"]["user"]['active'] != 1) {
4143
die("URL_REDIRECT: /index.php");
4244
//die();
4345
}
4446

45-
if(!preg_match("/^[a-z]{2,20}$/i", $mod)) die('module name contains unallowed chars.');
46-
if($redirect != '' && !preg_match("/^[a-z0-9]+\/[a-z0-9_\.\-]+\?id=[0-9]{1,9}(\&type=[a-z0-9_\.\-]+)?$/i", $redirect)) die('redirect contains unallowed chars.');
47+
if (!preg_match("/^[a-z]{2,20}$/i", $mod)) die('module name contains unallowed chars.');
48+
if ($redirect != '' && !preg_match("/^[a-z0-9]+\/[a-z0-9_\.\-]+\?id=[0-9]{1,9}(\&type=[a-z0-9_\.\-]+)?$/i", $redirect)) die('redirect contains unallowed chars.');
4749

4850
//* Check if user may use the module.
4951
$user_modules = explode(",", $_SESSION["s"]["user"]["modules"]);
5052

51-
if(!in_array($mod, $user_modules)) $app->error($app->lng(301));
53+
if (!in_array($mod, $user_modules)) $app->error($app->lng(301));
5254

5355
//* Load module configuration into the session.
54-
if(is_file($mod."/lib/module.conf.php")) {
56+
if (is_file($mod."/lib/module.conf.php")) {
5557
include_once $mod."/lib/module.conf.php";
5658

57-
$menu_dir = ISPC_WEB_PATH.'/' . $mod . '/lib/menu.d';
58-
59-
if (is_dir($menu_dir)) {
60-
if ($dh = opendir($menu_dir)) {
61-
//** Go through all files in the menu dir
62-
while (($file = readdir($dh)) !== false) {
63-
if ($file != '.' && $file != '..' && substr($file, -9, 9) == '.menu.php' && $file != 'dns_resync.menu.php') {
64-
include_once $menu_dir . '/' . $file;
65-
}
66-
}
67-
}
68-
}
59+
$menu_dir = ISPC_WEB_PATH.'/'.$mod.'/lib/menu.d';
60+
include_menu_dir_files($menu_dir);
6961

7062
$_SESSION["s"]["module"] = $module;
7163
session_write_close();
72-
if($redirect == ''){
64+
if ($redirect == '') {
7365
echo "HEADER_REDIRECT:".$_SESSION["s"]["module"]["startpage"];
7466
} else {
7567
//* If we click on a search result, load that one instead of the module's start page

interface/web/common.php

Lines changed: 53 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
1+
<?php
2+
3+
/*
4+
Copyright (c) 2007, Till Brehm, projektfarm Gmbh
5+
All rights reserved.
6+
7+
Redistribution and use in source and binary forms, with or without modification,
8+
are permitted provided that the following conditions are met:
9+
10+
* Redistributions of source code must retain the above copyright notice,
11+
this list of conditions and the following disclaimer.
12+
* Redistributions in binary form must reproduce the above copyright notice,
13+
this list of conditions and the following disclaimer in the documentation
14+
and/or other materials provided with the distribution.
15+
* Neither the name of ISPConfig nor the names of its contributors
16+
may be used to endorse or promote products derived from this software without
17+
specific prior written permission.
18+
19+
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
20+
ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
21+
WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
22+
IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT,
23+
INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
24+
BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25+
DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
26+
OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
27+
NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE,
28+
EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29+
*/
30+
31+
/*
32+
Some common helper functions which can be reused throughout the project.
33+
*/
34+
35+
/**
36+
* Includes all the menu files from the menu dir.
37+
* @param string $menu_dir Path to the menu dir
38+
* @return void
39+
*/
40+
function include_menu_dir_files($menu_dir)
41+
{
42+
if (is_dir($menu_dir)) {
43+
if ($dh = opendir($menu_dir)) {
44+
//** Go through all files in the menu dir
45+
while (($file = readdir($dh)) !== false) {
46+
if ($file != '.' && $file != '..' && substr($file, -9, 9) == '.menu.php' && $file != 'dns_resync.menu.php') {
47+
include_once $menu_dir.'/'.$file;
48+
}
49+
}
50+
}
51+
}
52+
}
53+

0 commit comments

Comments
 (0)