@@ -325,7 +325,7 @@ function add_dkim($data) {
325325 $ this ->remove_dkim_key ($ mail_config ['dkim_path ' ]."/ " .$ data ['new ' ]['domain ' ], $ data ['new ' ]['domain ' ]);
326326 }
327327 } else {
328- $ app ->log ('Error saving the DKIM Private-key for ' .$ data ['new ' ]['domain ' ].' - DKIM is not enabled for the domain. ' , LOGLEVEL_ERROR );
328+ $ app ->log ('Error saving the DKIM Private-key for ' .$ data ['new ' ]['domain ' ].' - DKIM is not enabled for the domain. ' , LOGLEVEL_DEBUG );
329329 }
330330 }
331331 }
@@ -369,45 +369,47 @@ function domain_dkim_insert($event_name, $data) {
369369 */
370370 function domain_dkim_update ($ event_name , $ data ) {
371371 global $ app ;
372- if ($ this ->check_system ($ data )) {
373- /* maildomain disabled */
374- if ($ data ['new ' ]['active ' ] == 'n ' && $ data ['old ' ]['active ' ] == 'y ' && $ data ['new ' ]['dkim ' ]=='y ' ) {
375- $ app ->log ('Maildomain ' .$ data ['new ' ]['domain ' ].' disabled - remove DKIM-settings ' , LOGLEVEL_DEBUG );
376- $ this ->remove_dkim ($ data ['new ' ]);
377- }
378- /* maildomain re-enabled */
379- if ($ data ['new ' ]['active ' ] == 'y ' && $ data ['old ' ]['active ' ] == 'n ' && $ data ['new ' ]['dkim ' ]=='y ' )
380- $ this ->add_dkim ($ data );
381-
382- /* maildomain active - only dkim changes */
383- if ($ data ['new ' ]['active ' ] == 'y ' && $ data ['old ' ]['active ' ] == 'y ' ) {
384- /* dkim disabled */
385- if ($ data ['new ' ]['dkim ' ] != $ data ['old ' ]['dkim ' ] && $ data ['new ' ]['dkim ' ] == 'n ' ) {
372+ if ($ data ['new ' ]['dkim ' ] == 'y ' || $ data ['old ' ]['dkim ' ] == 'y ' ){
373+ if ($ this ->check_system ($ data )) {
374+ /* maildomain disabled */
375+ if ($ data ['new ' ]['active ' ] == 'n ' && $ data ['old ' ]['active ' ] == 'y ' && $ data ['new ' ]['dkim ' ]=='y ' ) {
376+ $ app ->log ('Maildomain ' .$ data ['new ' ]['domain ' ].' disabled - remove DKIM-settings ' , LOGLEVEL_DEBUG );
386377 $ this ->remove_dkim ($ data ['new ' ]);
387378 }
388- /* dkim enabled */
389- elseif ($ data ['new ' ]['dkim ' ] != $ data ['old ' ]['dkim ' ] && $ data ['new ' ]['dkim ' ] == 'y ' ) {
390- $ this ->add_dkim ($ data );
391- }
392- /* new private-key */
393- if ($ data ['new ' ]['dkim_private ' ] != $ data ['old ' ]['dkim_private ' ] && $ data ['new ' ]['dkim ' ] == 'y ' ) {
394- $ this ->add_dkim ($ data );
395- }
396- /* new selector */
397- if ($ data ['new ' ]['dkim_selector ' ] != $ data ['old ' ]['dkim_selector ' ] && $ data ['new ' ]['dkim ' ] == 'y ' ) {
379+ /* maildomain re-enabled */
380+ if ($ data ['new ' ]['active ' ] == 'y ' && $ data ['old ' ]['active ' ] == 'n ' && $ data ['new ' ]['dkim ' ]=='y ' )
398381 $ this ->add_dkim ($ data );
382+
383+ /* maildomain active - only dkim changes */
384+ if ($ data ['new ' ]['active ' ] == 'y ' && $ data ['old ' ]['active ' ] == 'y ' ) {
385+ /* dkim disabled */
386+ if ($ data ['new ' ]['dkim ' ] != $ data ['old ' ]['dkim ' ] && $ data ['new ' ]['dkim ' ] == 'n ' ) {
387+ $ this ->remove_dkim ($ data ['new ' ]);
388+ }
389+ /* dkim enabled */
390+ elseif ($ data ['new ' ]['dkim ' ] != $ data ['old ' ]['dkim ' ] && $ data ['new ' ]['dkim ' ] == 'y ' ) {
391+ $ this ->add_dkim ($ data );
392+ }
393+ /* new private-key */
394+ if ($ data ['new ' ]['dkim_private ' ] != $ data ['old ' ]['dkim_private ' ] && $ data ['new ' ]['dkim ' ] == 'y ' ) {
395+ $ this ->add_dkim ($ data );
396+ }
397+ /* new selector */
398+ if ($ data ['new ' ]['dkim_selector ' ] != $ data ['old ' ]['dkim_selector ' ] && $ data ['new ' ]['dkim ' ] == 'y ' ) {
399+ $ this ->add_dkim ($ data );
400+ }
401+ /* new domain-name */
402+ if ($ data ['new ' ]['domain ' ] != $ data ['old ' ]['domain ' ]) {
403+ $ this ->remove_dkim ($ data ['old ' ]);
404+ $ this ->add_dkim ($ data );
405+ }
399406 }
400- /* new domain-name */
401- if ( $ data [ ' new ' ][ ' domain ' ] != $ data [ ' old ' ][ ' domain ' ]) {
402- $ this -> remove_dkim ($ data ['old ' ]);
407+
408+ /* resync */
409+ if ($ data ['new ' ][ ' active ' ] == ' y ' && $ data [ ' new ' ] == $ data [ ' old ' ] && $ data [ ' new ' ][ ' dkim ' ]== ' y ' ) {
403410 $ this ->add_dkim ($ data );
404411 }
405412 }
406-
407- /* resync */
408- if ($ data ['new ' ]['active ' ] == 'y ' && $ data ['new ' ] == $ data ['old ' ] && $ data ['new ' ]['dkim ' ]=='y ' ) {
409- $ this ->add_dkim ($ data );
410- }
411413 }
412414 }
413415
0 commit comments