Skip to content

Commit 8be19f1

Browse files
committed
fix tls1.3 in nginx
1 parent 91a7ecb commit 8be19f1

File tree

2 files changed

+4
-12
lines changed

2 files changed

+4
-12
lines changed

server/conf/nginx_vhost.conf.master

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,9 @@ server {
1919
</tmpl_if>
2020
</tmpl_if>
2121

22-
<tmpl_if name='tls1.3_supported' op='==' value='y'>
23-
<tmpl_var name="ssl_protocols">
22+
<tmpl_if name='tls13_supported' op='==' value='y'>
2423
ssl_protocols TLSv1.3 TLSv1.2;
2524
<tmpl_else>
26-
<tmpl_var name="ssl_protocols">
2725
ssl_protocols TLSv1.2;
2826
</tmpl_if>
2927
# ssl_ciphers 'ECDHE-ECDSA-CHACHA20-POLY1305:ECDHE-RSA-CHACHA20-POLY1305:ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-RSA-AES128-GCM-SHA256:ECDHE-ECDSA-AES256-GCM-SHA384:ECDHE-RSA-AES256-GCM-SHA384:DHE-RSA-AES128-GCM-SHA256:DHE-RSA-AES256-GCM-SHA384:ECDHE-ECDSA-AES128-SHA256:ECDHE-RSA-AES128-SHA256:ECDHE-ECDSA-AES128-SHA:ECDHE-RSA-AES256-SHA384:ECDHE-RSA-AES128-SHA:ECDHE-ECDSA-AES256-SHA384:ECDHE-ECDSA-AES256-SHA:ECDHE-RSA-AES256-SHA:DHE-RSA-AES128-SHA256:DHE-RSA-AES128-SHA:DHE-RSA-AES256-SHA256:DHE-RSA-AES256-SHA:ECDHE-ECDSA-DES-CBC3-SHA:ECDHE-RSA-DES-CBC3-SHA:EDH-RSA-DES-CBC3-SHA:AES128-GCM-SHA256:AES256-GCM-SHA384:AES128-SHA256:AES256-SHA256:AES128-SHA:AES256-SHA:DES-CBC3-SHA:!DSS';

server/plugins-available/nginx_plugin.inc.php

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1631,16 +1631,10 @@ function update($event_name, $data) {
16311631
// set logging variable
16321632
$vhost_data['logging'] = $web_config['logging'];
16331633

1634-
// Provide TLS 1.3 support if Nginx version is >= 1.13.0 and when it was linked against OpenSSL(>=1.1.1) at build time.
1635-
$output = $app->system->exec_safe('nginx -V 2>&1');
1636-
1637-
if(preg_match('/built with OpenSSL\s*(\d+)(\.(\d+)(\.(\d+))*)?(\D|$)/i', $output[0], $matches)) {
1638-
$nginx_openssl_ver = $matches[1] . (isset($matches[3]) ? '.' . $matches[3] : '') . (isset($matches[5]) ? '.' . $matches[5] : '');
1639-
}
1640-
1641-
if((version_compare($app->system->getnginxversion(true), '1.13.0', '>=') && version_compare($nginx_openssl_ver, '1.1.1', '>='))) {
1634+
// Provide TLS 1.3 support if Nginx version is >= 1.13.0 and when it was linked against OpenSSL(>=1.1.1) at build time.
1635+
if((version_compare($app->system->getnginxversion(true), '1.13.0', '>=') && version_compare($app->system->getopensslversion(true), '1.1.1', '>='))) {
16421636
$app->log('Enable TLS 1.3 for: '.$domain, LOGLEVEL_DEBUG);
1643-
$vhost_data['tls1.3_supported'] = 'y';
1637+
$vhost_data['tls13_supported'] = "y";
16441638
}
16451639

16461640
$tpl->setVar($vhost_data);

0 commit comments

Comments
 (0)