FS#3726 - Generated DKIM Selector has an invalid format

Florian Schaal · Florian Schaal · commit 8797b6fa1805 · 2014-11-03T22:12:22.000+01:00
diff --git a/interface/web/mail/mail_domain_dkim_create.php b/interface/web/mail/mail_domain_dkim_create.php
@@ -163,7 +163,7 @@ function new_selector ($old_selector, $domain) {
 echo "<privatekey>".$private_key."</privatekey>\n";
 echo "<publickey>".$public_key."</publickey>\n";
 if ( validate_domain($_POST['domain']) ) {
-	echo '<dns_record>'.$selector.'_domainkey.'.$_POST['domain'].'. 3600	TXT	"v=DKIM1; t=s; p='.$dns_record.'"</dns_record>';
+	echo '<dns_record>'.$selector.'._domainkey.'.$_POST['domain'].'. 3600	TXT	"v=DKIM1; t=s; p='.$dns_record.'"</dns_record>';
 }
 echo "</formatname>\n";
 ?>

Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,7 @@ function new_selector ($old_selector, $domain) {`
`163`	`163`	`echo "<privatekey>".$private_key."</privatekey>\n";`
`164`	`164`	`echo "<publickey>".$public_key."</publickey>\n";`
`165`	`165`	`if ( validate_domain($_POST['domain']) ) {`
`166`		`- echo '<dns_record>'.$selector.'_domainkey.'.$_POST['domain'].'. 3600 TXT "v=DKIM1; t=s; p='.$dns_record.'"</dns_record>';`
	`166`	`+ echo '<dns_record>'.$selector.'._domainkey.'.$_POST['domain'].'. 3600 TXT "v=DKIM1; t=s; p='.$dns_record.'"</dns_record>';`
`167`	`167`	`}`
`168`	`168`	`echo "</formatname>\n";`
`169`	`169`	`?>`