Update: Allow backup to complete if "file changed as we read it"

martin-enavn · martin-enavn · commit 838ed26786ce · 2017-06-15T15:04:11.000+02:00
diff --git a/server/lib/classes/cron.d/500-backup_mail.inc.php b/server/lib/classes/cron.d/500-backup_mail.inc.php
@@ -152,7 +152,7 @@ public function onRunJob() {
 							}
 						}
 						
-						if($retval <= 1){
+						if($retval == 0 || ($backup_mode != 'userzip' && $retval == 1) || ($backup_mode == 'userzip' && $retval == 12)){// tar can return 1, zip can return 12(due to harmless warings) and still create valid backups
 							chown($mail_backup_dir.'/'.$mail_backup_file, $backupusername);
 							chgrp($mail_backup_dir.'/'.$mail_backup_file, $backupgroup);
 							chmod($mail_backup_dir.'/'.$mail_backup_file, 0640);

Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,7 @@ public function onRunJob() {`
`152`	`152`	`}`
`153`	`153`	`}`
`154`	`154`
`155`		`- if($retval <= 1){`
	`155`	`+ if($retval == 0 \|\| ($backup_mode != 'userzip' && $retval == 1) \|\| ($backup_mode == 'userzip' && $retval == 12)){// tar can return 1, zip can return 12(due to harmless warings) and still create valid backups`
`156`	`156`	`chown($mail_backup_dir.'/'.$mail_backup_file, $backupusername);`
`157`	`157`	`chgrp($mail_backup_dir.'/'.$mail_backup_file, $backupgroup);`
`158`	`158`	`chmod($mail_backup_dir.'/'.$mail_backup_file, 0640);`