Skip to content

Commit 7acef04

Browse files
committed
Check only for active records when performing a duplicate check for mailboxes / aliases / forwarders
1 parent c5a7870 commit 7acef04

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

interface/web/mail/mail_alias_edit.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,8 @@ function onSubmit() {
120120
unset($this->dataRecord["email_local_part"]);
121121
unset($this->dataRecord["email_domain"]);
122122

123-
//* Check if there is no mailbox with this address
124-
$tmp = $app->db->queryOneRecord("SELECT count(mailuser_id) as number FROM mail_user WHERE email = '".$app->db->quote($this->dataRecord["source"])."'");
123+
//* Check if there is no active mailbox with this address
124+
$tmp = $app->db->queryOneRecord("SELECT count(mailuser_id) as number FROM mail_user WHERE postfix = 'y' AND email = '".$app->db->quote($this->dataRecord["source"])."'");
125125
if($tmp['number'] > 0) $app->tform->errorMessage .= $app->tform->lng("duplicate_mailbox_txt")."<br>";
126126
unset($tmp);
127127

interface/web/mail/mail_forward_edit.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,8 +117,8 @@ function onSubmit() {
117117
unset($this->dataRecord["email_local_part"]);
118118
unset($this->dataRecord["email_domain"]);
119119

120-
//* Check if there is no mailbox with this address
121-
$tmp = $app->db->queryOneRecord("SELECT count(mailuser_id) as number FROM mail_user WHERE email = '".$app->db->quote($this->dataRecord["source"])."'");
120+
//* Check if there is no active mailbox with this address
121+
$tmp = $app->db->queryOneRecord("SELECT count(mailuser_id) as number FROM mail_user WHERE postfix = 'y' AND email = '".$app->db->quote($this->dataRecord["source"])."'");
122122
if($tmp['number'] > 0) $app->tform->errorMessage .= $app->tform->lng("duplicate_mailbox_txt")."<br>";
123123
unset($tmp);
124124

interface/web/mail/mail_user_edit.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ function onSubmit() {
182182
$this->dataRecord["gid"] = $mail_config["mailuser_gid"];
183183

184184
//* Check if there is no alias or forward with this address
185-
$tmp = $app->db->queryOneRecord("SELECT count(forwarding_id) as number FROM mail_forwarding WHERE source = '".$app->db->quote($this->dataRecord["email"])."'");
185+
$tmp = $app->db->queryOneRecord("SELECT count(forwarding_id) as number FROM mail_forwarding WHERE active = 'y' AND source = '".$app->db->quote($this->dataRecord["email"])."'");
186186
if($tmp['number'] > 0) $app->tform->errorMessage .= $app->tform->lng("duplicate_alias_or_forward_txt")."<br>";
187187
unset($tmp);
188188

0 commit comments

Comments
 (0)