Fixed bug #265 cronjob creates emails on some systems.

Author: tbrehm

install/lib/installer_base.lib.php

@@ -895,9 +895,14 @@ public function install_crontab()
 		exec('crontab -u root -l > crontab.txt');
 		$existing_root_cron_jobs = file('crontab.txt');
 
+		// remove existing ispconfig cronjobs, in case the syntax has changed
+		foreach($existing_root_cron_jobs as $key => $val) {
+			if(stristr($val,'/usr/local/ispconfig')) unset($existing_root_cron_jobs[$key]);
+		}
+		
 		$root_cron_jobs = array(
-			'* * * * * /usr/local/ispconfig/server/server.sh &> /dev/null',
-			'30 00 * * * /usr/local/ispconfig/server/cron_daily.sh &> /dev/null'
+			'* * * * * /usr/local/ispconfig/server/server.sh > /dev/null',
+			'30 00 * * * /usr/local/ispconfig/server/cron_daily.sh > /dev/null'
 		);
 		foreach($root_cron_jobs as $cron_job) {
 			if(!in_array($cron_job."\n", $existing_root_cron_jobs)) {
@@ -913,7 +918,13 @@ public function install_crontab()
 		exec('crontab -u getmail -l > crontab.txt');
 		$existing_cron_jobs = file('crontab.txt');
 
-		$cron_jobs = array('*/5 * * * * '.$cf['program'].' -g '.$cf['config_dir'].' -r '.$cf['config_dir'].'/*.conf &> /dev/null');
+		$cron_jobs = array('*/5 * * * * '.$cf['program'].' -g '.$cf['config_dir'].' -r '.$cf['config_dir'].'/*.conf > /dev/null');
+		
+		// remove existing ispconfig cronjobs, in case the syntax has changed
+		foreach($cron_jobs as $key => $val) {
+			if(stristr($val,$cf['program'])) unset($cron_jobs[$key]);
+		}
+		
 		foreach($cron_jobs as $cron_job) {
 			if(!in_array($cron_job."\n", $existing_cron_jobs)) {
 				$existing_cron_jobs[] = $cron_job."\n";