Skip to content

Commit 7537db5

Browse files
author
Marius Burkard
committed
- Invalid value written to DB on "null" Fixes #3862
1 parent 5092278 commit 7537db5

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

interface/lib/classes/tform_base.inc.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -831,7 +831,7 @@ protected function _encode($record, $tab, $dbencode = true, $api = false) {
831831
}
832832

833833
//* Add slashes to all records, when we encode data which shall be inserted into mysql.
834-
if($dbencode == true) $new_record[$key] = $app->db->quote($new_record[$key]);
834+
if($dbencode == true && !is_null($new_record[$key])) $new_record[$key] = $app->db->quote($new_record[$key]);
835835
}
836836
}
837837
return $new_record;
@@ -1244,7 +1244,7 @@ protected function _getSQL($record, $tab, $action = 'INSERT', $primary_id = 0, $
12441244
}
12451245
} else {
12461246
$sql_insert_key .= "`$key`, ";
1247-
$sql_insert_val .= "'".$record[$key]."', ";
1247+
$sql_insert_val .= (is_null($record[$key]) ? 'NULL' : "'".$record[$key]."'") . ", ";
12481248
}
12491249
} else {
12501250
if($field['formtype'] == 'PASSWORD') {
@@ -1271,7 +1271,7 @@ protected function _getSQL($record, $tab, $action = 'INSERT', $primary_id = 0, $
12711271
$sql_update .= "`$key` = '".$record[$key]."', ";
12721272
}
12731273
} else {
1274-
$sql_update .= "`$key` = '".$record[$key]."', ";
1274+
$sql_update .= "`$key` = " . (is_null($record[$key]) ? 'NULL' : "'".$record[$key]."'") . ", ";
12751275
}
12761276
}
12771277
} else {

interface/web/sites/form/ftp_user.tform.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -296,8 +296,7 @@
296296

297297
$form['tabs']['advanced']['fields']['expires'] = array(
298298
'datatype' => 'DATETIME',
299-
'formtype' => 'DATETIME',
300-
'default' => null
299+
'formtype' => 'DATETIME'
301300
);
302301

303302

0 commit comments

Comments
 (0)