Skip to content

Commit 737d20c

Browse files
committed
revert number of backup copies to old behavior
1 parent 0113e85 commit 737d20c

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

server/lib/classes/backup.inc.php

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -691,11 +691,11 @@ protected static function get7zDecompressOptions($password)
691691
* @see backup_plugin::mount_backup_dir()
692692
* @author Ramil Valitov <ramilvalitov@gmail.com>
693693
*/
694-
protected static function clearBackups($server_id, $web_id, $max_backup_copies, $backup_dir)
694+
protected static function clearBackups($server_id, $web_id, $max_backup_copies, $backup_dir, $prefix_list=null)
695695
{
696696
global $app;
697697

698-
$files = self::get_files($backup_dir);
698+
$files = self::get_files($backup_dir, $prefix_list);
699699
usort($files, function ($a, $b) use ($backup_dir) {
700700
$time_a = filemtime($backup_dir . '/' . $a);
701701
$time_b = filemtime($backup_dir . '/' . $b);
@@ -1214,7 +1214,11 @@ protected static function make_database_backup($web_domain, $backup_job)
12141214

12151215
//* Remove old backups
12161216
self::backups_garbage_collection($server_id, 'mysql', $domain_id);
1217-
self::clearBackups($server_id, $domain_id, intval($rec['backup_copies']), $db_backup_dir);
1217+
$prefix_list = array(
1218+
'db_'.escapeshellarg($db_name).'_',
1219+
'manual-db_'.escapeshellarg($db_name).'_',
1220+
);
1221+
self::clearBackups($server_id, $domain_id, intval($rec['backup_copies']), $db_backup_dir, $prefix_list);
12181222
} else {
12191223
$app->log('Failed to process mysql backup format ' . $backup_format_db . ' for database ' . $rec['database_name'], LOGLEVEL_ERROR);
12201224
}
@@ -1324,7 +1328,11 @@ protected static function make_web_backup($web_domain, $backup_job)
13241328
$app->log('Backup of web files for domain ' . $web_domain['domain'] . ' failed using path ' . $web_path . ' failed.', LOGLEVEL_ERROR);
13251329
}
13261330

1327-
self::clearBackups($server_id, $web_id, intval($web_domain['backup_copies']), $web_backup_dir);
1331+
$prefix_list = array(
1332+
'web',
1333+
'manual-web',
1334+
);
1335+
self::clearBackups($server_id, $web_id, intval($web_domain['backup_copies']), $web_backup_dir, $prefix_list);
13281336
return true;
13291337
}
13301338

0 commit comments

Comments
 (0)