Skip to content

Commit 6c65d2b

Browse files
author
Marius Burkard
committed
Merge branch 'fix-proxy-https' into 'develop'
Fixed: Rewrite proxy for ssl targets See merge request ispconfig/ispconfig3!1521
2 parents 22bef49 + 55699e7 commit 6c65d2b

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

server/conf/vhost.conf.master

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -517,6 +517,9 @@
517517
RewriteCond %{REQUEST_URI} !^/php-fcgi/
518518
RewriteCond %{REQUEST_URI} !^<tmpl_var name='rewrite_target'>
519519
</tmpl_if>
520+
<tmpl_if name="rewrite_target_is_ssl" op="==" value="y">
521+
SSLProxyEngine On
522+
</tmpl_if>
520523

521524
RewriteRule ^/(.*)$ <tmpl_var name='rewrite_target'><tmpl_if name="rewrite_add_path" op="==" value="y">$1</tmpl_if> <tmpl_var name='rewrite_type'>
522525

server/plugins-available/apache2_plugin.inc.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1372,12 +1372,14 @@ function update($event_name, $data) {
13721372
$rewrite_rules[] = array('rewrite_domain' => '^'.$this->_rewrite_quote($data['new']['domain']),
13731373
'rewrite_type' => ($data['new']['redirect_type'] == 'no')?'':'['.$data['new']['redirect_type'].']',
13741374
'rewrite_target' => $rewrite_target,
1375+
'rewrite_target_is_ssl' => ('https://' === substr($rewrite_target, 0, 8) ? 'y' : 'n'),
13751376
'rewrite_target_ssl' => $rewrite_target_ssl,
13761377
'rewrite_is_url' => ($this->_is_url($rewrite_target) ? 'y' : 'n'),
13771378
'rewrite_add_path' => (substr($rewrite_target, -1) == '/' ? 'y' : 'n'));
13781379
$rewrite_rules[] = array('rewrite_domain' => '^' . $this->_rewrite_quote('www.'.$data['new']['domain']),
13791380
'rewrite_type' => ($data['new']['redirect_type'] == 'no')?'':'['.$data['new']['redirect_type'].']',
13801381
'rewrite_target' => $rewrite_target,
1382+
'rewrite_target_is_ssl' => ('https://' === substr($rewrite_target, 0, 8) ? 'y' : 'n'),
13811383
'rewrite_target_ssl' => $rewrite_target_ssl,
13821384
'rewrite_is_url' => ($this->_is_url($rewrite_target) ? 'y' : 'n'),
13831385
'rewrite_add_path' => (substr($rewrite_target, -1) == '/' ? 'y' : 'n'));
@@ -1386,6 +1388,7 @@ function update($event_name, $data) {
13861388
$rewrite_wildcard_rules[] = array( 'rewrite_domain' => '(^|\.)'.$this->_rewrite_quote($data['new']['domain']),
13871389
'rewrite_type' => ($data['new']['redirect_type'] == 'no')?'':'['.$data['new']['redirect_type'].']',
13881390
'rewrite_target' => $rewrite_target,
1391+
'rewrite_target_is_ssl' => ('https://' === substr($rewrite_target, 0, 8) ? 'y' : 'n'),
13891392
'rewrite_target_ssl' => $rewrite_target_ssl,
13901393
'rewrite_is_url' => ($this->_is_url($rewrite_target) ? 'y' : 'n'),
13911394
'rewrite_add_path' => (substr($rewrite_target, -1) == '/' ? 'y' : 'n'));
@@ -1394,6 +1397,7 @@ function update($event_name, $data) {
13941397
$rewrite_rules[] = array( 'rewrite_domain' => '^'.$this->_rewrite_quote($data['new']['domain']),
13951398
'rewrite_type' => ($data['new']['redirect_type'] == 'no')?'':'['.$data['new']['redirect_type'].']',
13961399
'rewrite_target' => $rewrite_target,
1400+
'rewrite_target_is_ssl' => ('https://' === substr($rewrite_target, 0, 8) ? 'y' : 'n'),
13971401
'rewrite_target_ssl' => $rewrite_target_ssl,
13981402
'rewrite_is_url' => ($this->_is_url($rewrite_target) ? 'y' : 'n'),
13991403
'rewrite_add_path' => (substr($rewrite_target, -1) == '/' ? 'y' : 'n'));

0 commit comments

Comments
 (0)