Skip to content

Commit 67feded

Browse files
author
Till Brehm
committed
Fixed: FS#3712 - Client DB credentials not escaped
1 parent ccebb93 commit 67feded

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

install/dist/lib/fedora.lib.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1292,7 +1292,7 @@ public function configure_dbserver()
12921292
$content = rfsel($conf['ispconfig_install_dir'].'/server/conf-custom/install/mysql_clientdb.conf.master', "tpl/mysql_clientdb.conf.master");
12931293
$content = str_replace('{hostname}', $conf['mysql']['host'], $content);
12941294
$content = str_replace('{username}', $conf['mysql']['admin_user'], $content);
1295-
$content = str_replace('{password}', $conf['mysql']['admin_password'], $content);
1295+
$content = str_replace('{password}', addslashes($conf['mysql']['admin_password']), $content);
12961296
wf("$install_dir/server/lib/mysql_clientdb.conf", $content);
12971297
exec('chmod 600 '."$install_dir/server/lib/mysql_clientdb.conf");
12981298
exec('chown root:root '."$install_dir/server/lib/mysql_clientdb.conf");

install/dist/lib/opensuse.lib.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1366,7 +1366,7 @@ public function configure_dbserver()
13661366
$content = rfsel($conf['ispconfig_install_dir'].'/server/conf-custom/install/mysql_clientdb.conf.master', "tpl/mysql_clientdb.conf.master");
13671367
$content = str_replace('{hostname}', $conf['mysql']['host'], $content);
13681368
$content = str_replace('{username}', $conf['mysql']['admin_user'], $content);
1369-
$content = str_replace('{password}', $conf['mysql']['admin_password'], $content);
1369+
$content = str_replace('{password}', addslashes($conf['mysql']['admin_password']), $content);
13701370
wf("$install_dir/server/lib/mysql_clientdb.conf", $content);
13711371
exec('chmod 600 '."$install_dir/server/lib/mysql_clientdb.conf");
13721372
exec('chown root:root '."$install_dir/server/lib/mysql_clientdb.conf");

install/lib/installer_base.lib.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2218,7 +2218,7 @@ public function configure_dbserver() {
22182218
$content = rfsel($conf['ispconfig_install_dir'].'/server/conf-custom/install/mysql_clientdb.conf.master', 'tpl/mysql_clientdb.conf.master');
22192219
$content = str_replace('{hostname}', $conf['mysql']['host'], $content);
22202220
$content = str_replace('{username}', $conf['mysql']['admin_user'], $content);
2221-
$content = str_replace('{password}', $conf['mysql']['admin_password'], $content);
2221+
$content = str_replace('{password}', addslashes($conf['mysql']['admin_password']), $content);
22222222
wf($install_dir.'/server/lib/mysql_clientdb.conf', $content);
22232223
chmod($install_dir.'/server/lib/mysql_clientdb.conf', 0600);
22242224
chown($install_dir.'/server/lib/mysql_clientdb.conf', 'root');

0 commit comments

Comments
 (0)