Skip to content

Commit 60b01b2

Browse files
author
Rajko Albrecht
committed
Don't use real textinputs for login_as and logout_from workflow. Some browser(-variants) fill them
with stored username/passwords and ignore the "value" attribute on post.
1 parent e7688c6 commit 60b01b2

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

interface/web/login/login_as.php

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -90,10 +90,8 @@
9090
<br /> <br /> <br /> <br />
9191
'.$wb['login_1_txt'].' ' . $dbData['username'] . '?<br />
9292
'.$wb['login_2_txt'].'<br />
93-
<div style="visibility:hidden">
94-
<input type="text" name="username" value="' . $dbData['username'] . '" />
95-
<input type="password" name="password" value="' . $dbData['passwort'] .'" />
96-
</div>
93+
<input type="hidden" name="username" value="' . $dbData['username'] . '" />
94+
<input type="hidden" name="password" value="' . $dbData['passwort'] .'" />
9795
<input type="hidden" name="s_mod" value="dashboard" />
9896
<input type="hidden" name="s_pg" value="dashboard" />
9997
<input type="hidden" name="login_as" value="1" />

interface/web/login/logout.php

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,8 @@
4848
echo '
4949
<br /> <br /> <br /> <br />
5050
'.str_replace('{UTYPE}', $utype, $wb['login_as_or_logout_txt']).'<br />
51-
<div style="visibility:hidden">
52-
<input type="text" name="username" value="' . $_SESSION['s_old']['user']['username'] . '" />
53-
<input type="password" name="password" value="' . $_SESSION['s_old']['user']['passwort'] .'" />
54-
</div>
51+
<input type="hidden" name="username" value="' . $_SESSION['s_old']['user']['username'] . '" />
52+
<input type="hidden" name="password" value="' . $_SESSION['s_old']['user']['passwort'] .'" />
5553
<input type="hidden" name="s_mod" value="login" />
5654
<input type="hidden" name="s_pg" value="index" />
5755
<input type="hidden" name="login_as" value="1" />

0 commit comments

Comments
 (0)