Deduplicate auth logging

Author: helmo

interface/lib/app.inc.php

@@ -208,6 +208,12 @@ public function log($msg, $priority = 0) {
 		}
 	}
 
+	public function auth_log($msg) {
+		$authlog_handle = fopen($this->_conf['ispconfig_log_dir'].'/auth.log', 'a');
+		fwrite($authlog_handle, $msg . PHP_EOL);
+		fclose($authlog_handle);
+	}
+
 	/** Priority values are: 0 = DEBUG, 1 = WARNING,  2 = ERROR */
 	public function error($msg, $next_link = '', $stop = true, $priority = 1) {
 		//$this->uses("error");

interface/web/login/index.php

@@ -264,11 +264,6 @@
 
 						$app->plugin->raiseEvent('login', $username);
 
-						//* Save successfull login message to var
-						$authlog = 'Successful login for user \''. $username .'\' from '. $_SERVER['REMOTE_ADDR'] .' at '. date('Y-m-d H:i:s') . ' with session ID ' .session_id();
-						$authlog_handle = fopen($conf['ispconfig_log_dir'].'/auth.log', 'a');
-						fwrite($authlog_handle, $authlog ."\n");
-						fclose($authlog_handle);
 
 						/*
 						* We need LOGIN_REDIRECT instead of HEADER_REDIRECT to load the
@@ -321,11 +316,7 @@
 				if($app->db->errorMessage != '') $error .= '<br />'.$app->db->errorMessage != '';
 
 				$app->plugin->raiseEvent('login_failed', $username);
-				//* Save failed login message to var
-				$authlog = 'Failed login for user \''. $username .'\' from '. $_SERVER['REMOTE_ADDR'] .' at '. date('Y-m-d H:i:s');
-				$authlog_handle = fopen($conf['ispconfig_log_dir'].'/auth.log', 'a');
-				fwrite($authlog_handle, $authlog ."\n");
-				fclose($authlog_handle);
+				$app->auth_log('Failed login for user \''. $username .'\' from '. $_SERVER['REMOTE_ADDR'] .' at '. date('Y-m-d H:i:s'));
 			}
 		}
 		} else {