use copy and unlink instead of rename. Might be universally the better option for all environments (i.e. NFS)

ms217 · ms217 · commit 57e3cd69199e · 2020-09-04T12:01:16.000+02:00
diff --git a/server/lib/classes/system.inc.php b/server/lib/classes/system.inc.php
@@ -935,7 +935,10 @@ function copy($file1, $file2) {
 	}
 
         function move($file1, $file2) {
-                return rename($file1, $file2);
+		return copy($file1, $file2);
+		if(file_exists($file1) || is_link($file1)) {
+                        return unlink($file1);
+                }
         }
 
 	function touch($file, $allow_symlink = false){

Original file line number	Diff line number	Diff line change
`@@ -935,7 +935,10 @@ function copy($file1, $file2) {`
`935`	`935`	`}`
`936`	`936`
`937`	`937`	`function move($file1, $file2) {`
`938`		`- return rename($file1, $file2);`
	`938`	`+ return copy($file1, $file2);`
	`939`	`+ if(file_exists($file1) \|\| is_link($file1)) {`
	`940`	`+ return unlink($file1);`
	`941`	`+ }`
`939`	`942`	`}`
`940`	`943`
`941`	`944`	`function touch($file, $allow_symlink = false){`