Merge branch '6350-skip-render-empty-zone' into 'develop'

Till Brehm · Till Brehm · commit 4e36ffb3f8ec · 2022-10-18T08:13:18.000Z
Skip rendering and reloading bind if there are no records, fixes #6350

Closes #6350

See merge request ispconfig/ispconfig3!1611
diff --git a/server/plugins-available/bind_plugin.inc.php b/server/plugins-available/bind_plugin.inc.php
@@ -323,6 +323,10 @@ function soa_update($event_name, $data) {
 					}
 				}
 			}
+			else {
+				$app->log("DNS zone[".$zone['origin']."] has no records yet, skip...", LOGLEVEL_DEBUG);
+				return;
+			}
 			$tpl->setLoop('zones', $records);
 
 			$filename = $dns_config['bind_zonefiles_dir'].'/' . $this->zone_file_prefix() . str_replace("/", "_", substr($zone['origin'], 0, -1));

Original file line number	Diff line number	Diff line change
`@@ -323,6 +323,10 @@ function soa_update($event_name, $data) {`
`323`	`323`	`}`
`324`	`324`	`}`
`325`	`325`	`}`
	`326`	`+ else {`
	`327`	`+ $app->log("DNS zone[".$zone['origin']."] has no records yet, skip...", LOGLEVEL_DEBUG);`
	`328`	`+ return;`
	`329`	`+ }`
`326`	`330`	`$tpl->setLoop('zones', $records);`
`327`	`331`
`328`	`332`	`$filename = $dns_config['bind_zonefiles_dir'].'/' . $this->zone_file_prefix() . str_replace("/", "_", substr($zone['origin'], 0, -1));`