Skip to content

Commit 46230ba

Browse files
author
Marius Cramer
committed
- wildcard domains not supported by letsencrypt, yet
1 parent a7b97c4 commit 46230ba

File tree

2 files changed

+16
-1
lines changed

2 files changed

+16
-1
lines changed

server/plugins-available/apache2_plugin.inc.php

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1113,6 +1113,12 @@ function update($event_name, $data) {
11131113

11141114
//* Generate Let's Encrypt SSL certificat
11151115
if($data['new']['ssl'] == 'y' && $data['new']['ssl_letsencrypt'] == 'y') {
1116+
if(substr($domain, 0, 2) === '*.') {
1117+
// wildcard domain not yet supported by letsencrypt!
1118+
$app->log('Wildcard domains not yet supported by letsencrypt, so changing ' . $domain . ' to ' . substr($domain, 2), LOGLEVEL_WARN);
1119+
$domain = substr($domain, 2);
1120+
}
1121+
11161122
$data['new']['ssl_domain'] = $domain;
11171123
$vhost_data['ssl_domain'] = $domain;
11181124

server/plugins-available/nginx_plugin.inc.php

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1153,6 +1153,15 @@ function update($event_name, $data) {
11531153
//* Generate Let's Encrypt SSL certificat
11541154
if($data['new']['ssl'] == 'y' && $data['new']['ssl_letsencrypt'] == 'y') {
11551155
//* be sure to have good domain
1156+
if(substr($domain, 0, 2) === '*.') {
1157+
// wildcard domain not yet supported by letsencrypt!
1158+
$app->log('Wildcard domains not yet supported by letsencrypt, so changing ' . $domain . ' to ' . substr($domain, 2), LOGLEVEL_WARN);
1159+
$domain = substr($domain, 2);
1160+
}
1161+
1162+
$data['new']['ssl_domain'] = $domain;
1163+
$vhost_data['ssl_domain'] = $domain;
1164+
11561165
$lddomain = (string) "$domain";
11571166
if($data['new']['subdomain'] == "www" OR $data['new']['subdomain'] == "*") {
11581167
$lddomain .= (string) " --domains www." . $domain;
@@ -1183,7 +1192,7 @@ function update($event_name, $data) {
11831192
$app->system->chmod($webroot . "/.well-known/acme-challenge", "g+s");
11841193

11851194
if(file_exists("/root/.local/share/letsencrypt/bin/letsencrypt")) {
1186-
$this->_exec("/root/.local/share/letsencrypt/bin/letsencrypt auth --text --agree-tos --authenticator=webroot --server=https://acme-v01.api.letsencrypt.org/directory --rsa-key-size=4096 --email postmaster@$domain --domains $lddomain --webroot-path " . escapeshellarg($webroot));
1195+
$this->_exec("/root/.local/share/letsencrypt/bin/letsencrypt auth --text --agree-tos --authenticator webroot --server https://acme-v01.api.letsencrypt.org/directory --rsa-key-size 4096 --email postmaster@$domain --domains $lddomain --webroot-path " . escapeshellarg($webroot));
11871196
}
11881197
};
11891198

0 commit comments

Comments
 (0)