Skip to content

Commit 426b47f

Browse files
author
ncomputers.org
committed
ServerAlias corrected
1 parent f6c9e04 commit 426b47f

File tree

1 file changed

+9
-19
lines changed

1 file changed

+9
-19
lines changed

server/plugins-available/apache2_plugin.inc.php

Lines changed: 9 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1422,31 +1422,31 @@ function update($event_name, $data) {
14221422
unset($client);
14231423
unset($aa_search);
14241424
unset($aa_replace);
1425-
$server_alias[] .= $auto_alias.' ';
1425+
$server_alias[] .= $auto_alias;
14261426
}
14271427

14281428
// get alias domains (co-domains and subdomains)
14291429
$aliases = $app->db->queryAllRecords("SELECT * FROM web_domain WHERE parent_domain_id = ? AND active = 'y' AND (type != 'vhostsubdomain' AND type != 'vhostalias')", $data['new']['domain_id']);
14301430
$alias_seo_redirects = array();
14311431
switch($data['new']['subdomain']) {
14321432
case 'www':
1433-
$server_alias[] = 'www.'.$data['new']['domain'].' ';
1433+
$server_alias[] = 'www.'.$data['new']['domain'];
14341434
break;
14351435
case '*':
1436-
$server_alias[] = '*.'.$data['new']['domain'].' ';
1436+
$server_alias[] = '*.'.$data['new']['domain'];
14371437
break;
14381438
}
14391439
if(is_array($aliases)) {
14401440
foreach($aliases as $alias) {
14411441
switch($alias['subdomain']) {
14421442
case 'www':
1443-
$server_alias[] .= 'www.'.$alias['domain'].' '.$alias['domain'].' ';
1443+
$server_alias[] .= 'www.'.$alias['domain'].' '.$alias['domain'];
14441444
break;
14451445
case '*':
1446-
$server_alias[] .= '*.'.$alias['domain'].' '.$alias['domain'].' ';
1446+
$server_alias[] .= '*.'.$alias['domain'].' '.$alias['domain'];
14471447
break;
14481448
default:
1449-
$server_alias[] .= $alias['domain'].' ';
1449+
$server_alias[] .= $alias['domain'];
14501450
break;
14511451
}
14521452
$app->log('Add server alias: '.$alias['domain'], LOGLEVEL_DEBUG);
@@ -1513,22 +1513,12 @@ function update($event_name, $data) {
15131513
}
15141514

15151515
//* If we have some alias records
1516-
if(count($server_alias) > 0) {
1517-
$server_alias_str = '';
1518-
$n = 0;
1519-
1520-
// begin a new ServerAlias line after 30 alias domains
1521-
foreach($server_alias as $tmp_alias) {
1522-
if($n % 30 == 0) $server_alias_str .= "\n ServerAlias ";
1523-
$server_alias_str .= $tmp_alias;
1524-
}
1525-
unset($tmp_alias);
1526-
1527-
$tpl->setVar('alias', trim($server_alias_str));
1516+
if($server_alias)) {
1517+
$tpl->setVar('alias', 'ServerAlias '.implode(' ',$server_alias));
15281518
} else {
15291519
$tpl->setVar('alias', '');
15301520
}
1531-
1521+
15321522
if (count($rewrite_wildcard_rules) > 0) $rewrite_rules = array_merge($rewrite_rules, $rewrite_wildcard_rules); // Append wildcard rules to the end of rules
15331523

15341524
if(count($rewrite_rules) > 0 || $vhost_data['seo_redirect_enabled'] > 0 || count($alias_seo_redirects) > 0 || $data['new']['rewrite_to_https'] == 'y') {

0 commit comments

Comments
 (0)